Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra UI] Use the official KibanaThemeProvider in the logs and metrics apps #118877

Closed
weltenwort opened this issue Nov 17, 2021 · 1 comment · Fixed by #120164
Closed

[Infra UI] Use the official KibanaThemeProvider in the logs and metrics apps #118877

weltenwort opened this issue Nov 17, 2021 · 1 comment · Fixed by #120164
Assignees
Labels
Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.1.0

Comments

@weltenwort
Copy link
Member

📓 Summary

In order to support the new theming mechanism of EUI we need to include the recently added <KibanaThemeProvider> in the app component hierarchy.

part of #118866

✔️ Acceptance criteria

  • The renderApp functions of the logs app wraps the hierarchy into a <KibanaThemeProvider> with props from the core theme$ argument.
  • The renderApp functions of the metrics app wraps the hierarchy into a <KibanaThemeProvider> with props from the core theme$ argument.

💡 Implementation hints

@weltenwort weltenwort added Feature:Metrics UI Metrics UI feature Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Nov 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants