Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Linting: add checks for unhandled promises #118349

Open
banderror opened this issue Nov 11, 2021 · 3 comments
Open

[Security Solution] Linting: add checks for unhandled promises #118349

banderror opened this issue Nov 11, 2021 · 3 comments
Labels
Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture

Comments

@banderror
Copy link
Contributor

Summary

In order to be able to catch bugs in the code like this one #118171, is it possible to check for unhandled promises via a linter rule or any other way?
@banderror banderror added Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Nov 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@spong spong added the Team:Security Solution Platform Security Solution Platform Team label Nov 16, 2021
@spong
Copy link
Member

spong commented Nov 17, 2021

There were recent efforts to try and add @typescript-eslint/no-floating-promises but it was ultimately removed from the final PR.

Looks like the plan is to get it added and then enable plugin-by-plugin:

I'm not planning on forcing plugins to enable it as of right now, but I think it's a reasonable initiative if folks think it's a good idea. The plan is for plugins to opt-into for now.

@banderror banderror added the technical debt Improvement of the software architecture and operational architecture label Nov 23, 2021
@yctercero yctercero added Team:Detection Engine Security Solution Detection Engine Area and removed Team:Security Solution Platform Security Solution Platform Team labels May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@spong @banderror @yctercero @elasticmachine