Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine es and ese search strategies #118165

Closed
Tracked by #166068
timroes opened this issue Nov 10, 2021 · 5 comments
Closed
Tracked by #166068

Combine es and ese search strategies #118165

timroes opened this issue Nov 10, 2021 · 5 comments
Labels
discuss Feature:Search Querying infrastructure in Kibana Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@timroes
Copy link
Contributor

timroes commented Nov 10, 2021

We currently have an es strategy (the old OSS strategy), which can only request data via _search and the ese search strategy, which supports async search and rollups. I feel this is a bit of a weird (most likely historical grown mix), since e.g. if you're using the es strategy to not get async search you'd automatically also lose access to querying rollup.

I wanted to discuss if it could be worth merging those two into one es search strategy, where async search and rollup support would simply be available parameters to turn it off or on. I feel that way it might be easier to maintain them in the future, especially if we'll start adding support for other features into them.

@timroes timroes added Feature:Search Querying infrastructure in Kibana discuss Team:AppServicesSv labels Nov 10, 2021
@timroes
Copy link
Contributor Author

timroes commented Nov 10, 2021

cc @lukasolson @ppisljar

@Dosant
Copy link
Contributor

Dosant commented Nov 11, 2021

Not sure what is the plan about merging the strategies, but at some point, we thought of moving rollup search into its own strategy #98122

@timroes
Copy link
Contributor Author

timroes commented Nov 11, 2021

The problem that I'd see about that (but I could have a false understanding here): The consumer of the API needs to select the strategy, meaning whoever wants to use a search strategy then would suddenly need to do a check: is the index pattern rollup, if so get a different search strategies and request it. That makes imho consumption of the search service significantly more complex. Looking through the PR you linked it seems we're currenlty doing that in SearchSource, but that might just be one place, and all direct consumers of the Search Service will suddenly need to repeat that logic all over the place. I am a bit concerned if that really makes that service better to consume and if it's not better combining search strategies and just have them determine those differences they can detect automatically internally.

@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort labels Nov 18, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort and removed loe:small Small Level of Effort impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Jun 14, 2022
@petrklapka petrklapka added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:AppServicesSv labels Nov 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal
Copy link
Member

kertal commented Oct 25, 2023

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

@kertal kertal closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
@kertal kertal added the Icebox label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Feature:Search Querying infrastructure in Kibana Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

5 participants