Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Field statistics design issues #117602

Closed
3 of 6 tasks
andreadelrio opened this issue Nov 4, 2021 · 8 comments
Closed
3 of 6 tasks

[Discover] Field statistics design issues #117602

andreadelrio opened this issue Nov 4, 2021 · 8 comments
Assignees
Labels
Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Meta Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@andreadelrio
Copy link
Contributor

andreadelrio commented Nov 4, 2021

  • Improve layouts of expanded rows, the following are some examples of what we could improve

image
image
image

  • Address the difference between keyword and text fields. Tooltips could be a way to do this but we should evaluate alternatives too

  • Start using Eui's tokenKeyword for the keyword fields

  • Consider an alternative location for the toggle Document View / Field Statistics. To do: explore placing it on the left sidebar

  • Improve mini distribution charts. Some examples pointed out by internal testers

image

image

Nice to haves

  • Switch the Lens graph that opens from Field Statistics from line to bars (to match the graph type that users see in Field Statistics) view (this suggestion came from internal testing)
@andreadelrio andreadelrio added Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Nov 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@rayafratkina
Copy link
Contributor

@andreadelrio wanted to share @teresaalvarezsoler's observation as a new user: the "field statistic" option should be placed under the chart, where the documents start since it is changing the documents view and not the chart view.
I think that makes a lot of sense. Have we considered that option?

@andreadelrio
Copy link
Contributor Author

@andreadelrio wanted to share @teresaalvarezsoler's observation as a new user: the "field statistic" option should be placed under the chart, where the documents start since it is changing the documents view and not the chart view. I think that makes a lot of sense. Have we considered that option?

@rayafratkina Yes, this comment also came up when we did some internal testing. I made a proposal a while back for this which Quynh and her team seemed to be on board with. We agreed to wait til DataGrid was on by default so now it's a great time to consider doing this. Since vertical space is scarce in Discover I tried coming up with an idea where the switch wouldn't take up additional vertical space (at least in the Documents view). Let me know what you think of this.

toggle datagrid header right - doc view

toggle datagrid header right - field stats

@teresaalvarezsoler
Copy link

@andreadelrio this looks much better. I also think it provides the correct level of importance to the option.

By the way, I was expecting to find an option like that one to change from the JSON view to the table view. It was super difficult to realize that I should click in the small "+" icon in the fields in the left to get the columns. Also it's very painful to get a table view with all the fields in it since it's a lot of clicks!. I submit all the feedback in the form, I hope it helps.

@kertal
Copy link
Member

kertal commented Mar 9, 2022

Problem here is, that the latest changes in the EuiDataGrid made this area populated:
Discover_-_Elastic

@andreadelrio
Copy link
Contributor Author

Problem here is, that the latest changes in the EuiDataGrid made this area populated: Discover_-_Elastic

Ah, good point! I had an old screenshot. It looks like Unified Search will free up a bit of vertical space in Discover so we might be ok adding an extra row to include the toggle below the histogram.

@kertal
Copy link
Member

kertal commented Jun 28, 2022

@andreadelrio since this is labeled as complete, can we close this?

@timductive
Copy link
Member

Another potential design issue to address: #136299

@davismcphee davismcphee added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated labels Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Meta Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

7 participants