Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert remaining Core-owned *.js files into *.ts #117123

Closed
mshustov opened this issue Nov 2, 2021 · 6 comments
Closed

Convert remaining Core-owned *.js files into *.ts #117123

mshustov opened this issue Nov 2, 2021 · 6 comments
Assignees
Labels
DX Issues related to Developer Experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture

Comments

@mshustov
Copy link
Contributor

mshustov commented Nov 2, 2021

Github issue description exceeds 32767 characters. This is too long for Jira. See the GH issue.

@mshustov mshustov added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture labels Nov 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@mshustov mshustov added DX Issues related to Developer Experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Nov 2, 2021
@pgayvallet pgayvallet self-assigned this Nov 2, 2021
@pgayvallet
Copy link
Contributor

The Core code contains just 4 leftovers

3:

  • src/core/server/saved_objects/service/lib/scoped_client_provider.test.js
  • src/core/server/saved_objects/service/saved_objects_client.test.js
  • src/core/server/saved_objects/service/lib/repository.test.js

The last one is src/core/jest.config.js

@pgayvallet
Copy link
Contributor

Gonna wait until #117056 is merged for repository.test.js, as this PR impacts the file

@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Nov 4, 2021
@pgayvallet
Copy link
Contributor

#117259 is going to remove the last javascript files from /src/core.

I checked our owned plugins and packages, and the only ones still having javascript files are:

  • /src/plugins/home/ 30 files

  • /src/plugins/kibana_overview/ (TIL we own this thing) 3 files

    • such as src/plugins/kibana_overview/public/components/synopsis/synopsis.js
  • packages/kbn-i18n, 1 file

    • packages/kbn-i18n/src/core/locales.js

Note that most FTR tests are not code-owner assigned, so we probably have some javascript files in /test and /x-pack/test too, such as test/api_integration/apis/status/status.js

@mshustov
Copy link
Contributor Author

mshustov commented Nov 5, 2021

/src/plugins/home/ 30 files

😭

Note that most FTR tests are not code-owner assigned, so we probably have some javascript files in /test and /x-pack/test too, such as test/api_integration/apis/status/status.js

ok, I hope we can do it #116415. Also, in the future, all the functional tests will be under appropriate domain folders.

@pgayvallet
Copy link
Contributor

We're no longer owners of the home plugin, and all other files have been converted to typescript. This can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues related to Developer Experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

3 participants