Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retrieval of cluster settings when determining deprecation logging status #116322

Closed
cjcenizal opened this issue Oct 26, 2021 · 1 comment
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@cjcenizal
Copy link
Contributor

There's a typo in the UA logic on these lines:

const clusterDeprecationLoggingEnabled = ['default', 'persistent', 'transient'].reduce(

const deprecationLogLevel = ['default', 'persistent', 'transient'].reduce(

in both cases, default should be defaults. You can see that when we retrieve cluster settings with the defaults, they're namespaced under the defaults object:

image

This should fix a bug that @jakelandis and @pgomulka found, in which deprecation logging should be enabled by default, but UA reports it as disabled by default.

@cjcenizal cjcenizal added bug Fixes for quality problems that affect the customer experience Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Upgrade Assistant labels Oct 26, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

3 participants