Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search Sessions] Improve functional tests due to a warning on fail to restore a search #116148

Closed
Tracked by #166068
Dosant opened this issue Oct 25, 2021 · 2 comments
Closed
Tracked by #166068
Labels
Feature:Search Sessions Feature:Search Querying infrastructure in Kibana Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@Dosant
Copy link
Contributor

Dosant commented Oct 25, 2021

During work on #113950 there was a single test failure related to search sessions:

// SKIPPED - see https://github.com/elastic/kibana/pull/113950 
 // `expect(await toasts.getToastCount()).to.be(0)` fails because of a `Your search session is still running` toast 
 // rest of the test does pass 
 it.skip('relative timerange works', async () => { 

It turned out that the search session feature was broken at that point with failing to restore any searches. Most of the tests were passing, but only a single failure.

We need to review our tests so that in case the feature is degraded there is a more obvious indication of a problem:

During the initial feature, implementation searches were failed (and tests) in case of no search hash match during session restoration. But in #102057 we allowed searches to proceed with a warning in case no matches. With that change, we didn't properly update our tests to check if there are warnings that we don't expect.
As work on #113950 showed, the current test suite mostly passes in case searches can't be restored

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Nov 18, 2021
@petrklapka petrklapka added Feature:Search Querying infrastructure in Kibana Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:AppServicesSv labels Nov 21, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal
Copy link
Member

kertal commented Oct 30, 2023

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

@kertal kertal added the Icebox label Oct 30, 2023
@kertal kertal closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Search Sessions Feature:Search Querying infrastructure in Kibana Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

4 participants