Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-skip migration batch size test #116111

Closed
mshustov opened this issue Oct 25, 2021 · 5 comments · Fixed by #119791
Closed

Un-skip migration batch size test #116111

mshustov opened this issue Oct 25, 2021 · 5 comments · Fixed by #119791
Labels
Feature:elasticsearch impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort skipped-test Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture

Comments

@mshustov
Copy link
Contributor

I had to skip a SO migration integration test
b88c94c
due to a bug in Elasticsearch elastic/elasticsearch#79684

Un-skip the test when either the bug is fixed in Elasticsearch or elasticsearch-js implements a workaround.

@mshustov mshustov added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture labels Oct 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@rudolf
Copy link
Contributor

rudolf commented Oct 26, 2021

Also affects the currently skipped test "resolves left request_entity_too_large_exception when the payload is too large" https://github.com/elastic/kibana/blob/master/src/core/server/saved_objects/migrationsv2/actions/integration_tests/actions.test.ts#L1542

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Nov 2, 2021
@mshustov mshustov added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Nov 2, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort loe:small Small Level of Effort and removed loe:small Small Level of Effort loe:medium Medium Level of Effort labels Nov 4, 2021
@mshustov
Copy link
Contributor Author

test fixtures must be updated. after the root cause was resolved, the test fails with

[Error: Unable to complete saved object migrations for the [.kibana] index: Migration failed because documents were found for unknown saved object types. To proceed with the migration, please delete these documents from the ".kibana_7.14.0_001" index.
    The documents with unknown types are:
    - "graph-workspace:46fa9d30-319c-11ea-bbe4-818d9c786051" (type: "graph-workspace")
    - "canvas-workpad:workpad-e08b9bdb-ec14-4339-94c4-063bddfd610e" (type: "canvas-workpad")
    - "canvas-workpad-template:workpad-template-029bdeb3-40a6-4c90-9320-a5566abaf427" (type: "canvas-workpad-template")
    - "canvas-workpad-template:workpad-template-aefa8b2b-24ec-4093-8a59-f2cbc5f7c947" (type: "canvas-workpad-template")
    - "canvas-workpad-template:workpad-template-6181471b-147d-4397-a0d3-1c0f1600fa12" (type: "canvas-workpad-template")
    - "canvas-workpad-template:workpad-template-890b80e5-a3eb-431d-b8ed-37587ffd32c3" (type: "canvas-workpad-template")
    - "map:2c9c1f60-1909-11e9-919b-ffe5949a18d2" (type: "map")
    - "ingest-outputs:74bfb940-041c-11ec-8362-6320c0ce3cd3" (type: "ingest-outputs")
    - "space:default" (type: "space")
    - "ingest_manager_settings:5b160d50-041c-11ec-8362-6320c0ce3cd3" (type: "ingest_manager_settings")
    You can delete them using the following command:
    curl -X POST "{elasticsearch}/.kibana_7.14.0_001/_bulk?pretty" -H 'Content-Type: application/json' -d'
    { "delete" : { "_id" : "graph-workspace:46fa9d30-319c-11ea-bbe4-818d9c786051" } }
    { "delete" : { "_id" : "canvas-workpad:workpad-e08b9bdb-ec14-4339-94c4-063bddfd610e" } }
    { "delete" : { "_id" : "canvas-workpad-template:workpad-template-029bdeb3-40a6-4c90-9320-a5566abaf427" } }
    { "delete" : { "_id" : "canvas-workpad-template:workpad-template-aefa8b2b-24ec-4093-8a59-f2cbc5f7c947" } }
    { "delete" : { "_id" : "canvas-workpad-template:workpad-template-6181471b-147d-4397-a0d3-1c0f1600fa12" } }
    { "delete" : { "_id" : "canvas-workpad-template:workpad-template-890b80e5-a3eb-431d-b8ed-37587ffd32c3" } }
    { "delete" : { "_id" : "map:2c9c1f60-1909-11e9-919b-ffe5949a18d2" } }
    { "delete" : { "_id" : "ingest-outputs:74bfb940-041c-11ec-8362-6320c0ce3cd3" } }
    { "delete" : { "_id" : "space:default" } }
    { "delete" : { "_id" : "ingest_manager_settings:5b160d50-041c-11ec-8362-6320c0ce3cd3" } }
    ']

Also affects the currently skipped test "resolves left request_entity_too_large_exception when the payload is too large" https://github.com/elastic/kibana/blob/master/src/core/server/saved_objects/migrationsv2/actions/integration_tests/actions.test.ts#L1542

This one is fixed by #119791

@pgayvallet
Copy link
Contributor

test fixtures must be updated

This is caused by the presence of xpack types in the dataset. Changing oss: true to oss: false such as done here

should do the trick

@mshustov
Copy link
Contributor Author

@pgayvallet I agree, especially in the light of the necessity to remove oss: false from the integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:elasticsearch impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort skipped-test Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants