-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] The Event Details Panel > Table view sometimes displays unexpected values when filtered #115984
Comments
Pinging @elastic/security-solution (Team: SecuritySolution) |
@MadameSheema, the previously theoretical discussion re: React keys in #115141 identified this as a potential issue and fixed it in #115141 Would the team be willing to:
? |
We have validated this ticket on 7.15.0 and 7.16.0 BC1 on-prem and Please find our below observations: 7.15.0 🔴Threat Fields search with keyword threat Threat Fields search without the keyword threat Other Fields on search without the keyword _index Host.ip Fields on table tab and json 7.16.0 BC1Build Details:
Threat Fields on Alerts Page ✔️ Threat Fields on Hosts Page ✔️ Threat Fields on Alerts Page search without the keyword threat ✔️ Threat Fields on Hosts Page search without the keyword threat ✔️ Other Fields on search without the keyword _index ✔️ Other Fields on search with the keyword _index ✔️ Host.ip Fields on table tab and json under Alerts Page ✔️ Host.ip Fields on table tab and json under Hosts Page ✔️ Note:7.16.0 BC1 cloud production build is not available yet, we will perform the upgrade scenarios once the cloud build is available. Please let us know if we are missing something. Thanks!! cc: @MadameSheema |
We have validated this ticket on Upgrade the 7.15.0 to 7.16 BC1 and Please find our below observations: After upgrade to 7.16.0 BC1Build Details:
Threat Fields on Alerts Page ✔️ Threat Fields on Hosts Page ✔️ Other Fields on search with the keyword _index ✔️ Host.ip Fields on table tab and json under Alerts Page ✔️ Host.ip Fields on table tab and json under Hosts Page ✔️ Kindly let us know if anything else is required from our end or else we are good to close this issue. Thanks!! cc: @MadameSheema |
@andrew-goldstein can you please take a look at the above? Thanks :) |
Thanks @deepikakeshav-qasource for verifying that upgrading to |
Describe the bug:
@threat-punter reports:
Above: In the screenshot provided by David, the view is filtered by the text
threat
, and shows unexpected values for some fieldsReproducing the issue in a cloud-deployed
7.15
buildThe issue was reproduced by accessing the Elastic Cloud-deployed
7.15
build of Kibana, and viewing a specific event_id: "U_EwgXwBQyGN7Uu9IgYB"
in theHost > Events
view, as shown in the screenshot below:Above: Reproduced in the cloud-deployed
7.15
build of Kibana, hosted in Elastic CloudWhen the
threat
filter shown in the screenshot above was removed, the fields displayed their expected values, as shown in the screenshot below:Reproducing the issue filtering by
_index
The issue is not specific to
threat.*
fields.For example, the expected value for
_index
is displayed correctly (using the cloud-deployed7.15
build of Kibana) when the view is unfiltered:Above: The expected value for
_index
is displayed correctly when the view is unfilteredWhen the text
_filter
is added to the filter, the value for_index
includes (unexpected) JSON:Above: Filtering by
_index
displays unexpected JSON instead of the expected value,.ds-logs-endpoint.alerts-default-2021.09.23-000001
Although the data shown in the table appears to be corrupted, the correct value for
_index
is copied to the clipboard when users select theCopy to clipboard
action for the_index
field, as shown in the screenshot below:Above: the correct value for
_index
is copied to the clipboard, even when the data appears corruptedReference: The raw event (via
Dev Tools
)For reference, the raw event used to reproduce the screenshots above was retrieved via
Dev Tools
:and pasted into the
Click to expand
section below:Click to expand / view the JSON view of the event used to reproduce the issue
A related React
key
issueThe values displayed in table view are rendered by the
FieldValueCell
component in the following file:A React
key
issue was recently spotted and fixed in this file while working on an unrelated enhancement #115141The exact line in question changed the value of the
key
from:to
The PR contains the following explanation of the change:
At the time of the PR review above, this discussion was just theoretical, but per the next section below, applying the changes in that PR directly to the
7.15
branch resolves the issue when running a local Kibana instance against the same cloud deployment.Applying the
key
changes to the7.15
branchFirst, the issue was reproduced with a local checkout of the
7.15
branch, connected to the cloud deployment:Above: The issue reproduced with a local checkout of
7.15
, connected to the cloud deploymentNext the two changes to the React
key
s inx-pack/plugins/security_solution/public/common/components/event_details/table/field_value_cell.tsx
are applied directly to a local checkout of the Kibana7.15
branch, as shown in the diff below:Above: The key changes applied to a local checkout of
7.15
After making the key changes above, filtering by
_index
shows the correct value, as shown in the screenshot below:Above: Filtering by
_index
shows the correct value when thekey
fixes are applied directly to the local checkout of7.15
Filtering by
threat
also works correctly, even when multiple fields have the same value, for example:and
as shown in the screenshot below:
Above: Filtering by
threat
works correctly, even when multiple fields have the same valueDuplicate field values when no filter is applied
You may have noticed that some fields had duplicate values, even when no filter was applied. For example the following screenshot is from the cloud-deployed version of Kibana:
Above: other fields, unfiltered, in the cloud-deployed version of Kibana
In the screenshot above, the
Events.user.name
displays the valueroot
four times in the unfiltered view. Applying the Reactkey
fix described in the previous section does not change this behavior.To better understand why this behavior, the raw JSON from the output of the following
Dev Tools
query:was copy-pasted into a JSON formatter that supported collapsing regions, as shown in screenshot below:
Above: The JSON representation of the event, collapsed to only show
Events
Per the screenshot above:
_source
document contains anarray
ofEvents
Events
array contains four objectsEvents
array have a child object nameduser
When expanded, all four
Events.user.name
s have the valueroot
, as shown in the screenshot below:Above: all four
Events.user.name
s have the valueroot
Using the technique above, the duplicate values were all found to be contained in the original source event, which is included in this issue. (The attached event may be re-indexed to verify the fix.)
Kibana/Elasticsearch Stack version:
7.15
Original install method (e.g. download page, yum, from source, etc.):
Elastic Cloud
The text was updated successfully, but these errors were encountered: