Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discuss] Action group consistency across rule types: how? #115973

Closed
jasonrhodes opened this issue Oct 21, 2021 · 2 comments
Closed

[Discuss] Action group consistency across rule types: how? #115973

jasonrhodes opened this issue Oct 21, 2021 · 2 comments
Labels
discuss Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@jasonrhodes
Copy link
Member

Before we embark on an RFC with a proposal on how we might achieve this, I wanted to provide context about the problem I think we're facing with the existing alert framework.

Problem Statement

Currently, a rule type can create any action group it likes [1]. Rule Type A might do the following:

  • If condition 1 is true, schedule the "blue" action group
  • If condition 2 is true, schedule the "red" action group
  • If conditions 1 and 2 are both true, schedule the "purple" action group
  • If neither are true, schedule nothing

Whereas Rule Type B may do similar checks, but schedule entirely different groups (named "Info", "Warn", and "Critical", for example). For flexibility purposes, this is powerful.

In the rule management UI, Rule Type A might show up with something like this:
Screen Shot 2021-10-21 at 11 56 45 AM

with the ability to set the various conditions or thresholds above this UI for each of the action group conditions.

[1] Is this true?

Question 1

How can a subset of rule types share a consistent action group experience?

This is important because we are considering allowing rule types to opt into a "no data" action group so that users can configure different action/connector set up to be triggered when the current rule encounters a lack of data when it expects data to evaluate.

Question 2

Given some answer to Question 1, how do we ensure those rule types can convert those action groups into alerts as data field values?

This is important because there is a desire to use action groups to power the idea of "alert severity", but without a way to ensure consistency between rule types, and to limit which action groups should be mapped to which AAD fields, this will become rather complicated and error-prone.

@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 21, 2021
@kertal kertal added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Dec 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 15, 2021
@pmuellr
Copy link
Member

pmuellr commented Jan 14, 2022

Thanks for raising this! Way back, we realized the lack of consistency was going to be a problem, but we also didn't really have any experience to know what we should be doing here. Seems like we have some now!

This is important because we are considering allowing rule types to opt into a "no data" action group

We already have a "free" action group (any rule can use it) - recovered. "no data" has been on the radar for a while now, but I can't remember the issues surrounding it. And IIRC the "no data" discussions pre-date the need for the recovered action. Perhaps we were reticent to add "free" action groups at the time, when looking into "no data" or something. Seems like adding a new "free" action group - no data would be appropriate now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
Development

No branches or pull requests

5 participants