Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering out on spy panel in discover doesn't work. #11470

Closed
bhavyarm opened this issue Apr 27, 2017 · 5 comments · Fixed by #16387
Closed

Filtering out on spy panel in discover doesn't work. #11470

bhavyarm opened this issue Apr 27, 2017 · 5 comments · Fixed by #16387
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Feature:Filters Feature:Inspector Inspector infrastructure and implementations Feature:Visualizations Generic visualization features (in case no more specific feature label is available) good first issue low hanging fruit

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Apr 27, 2017

Kibana version: 5.4.0 (BC3)

Elasticsearch version: 5.4.0(BC3)

Server OS version: darwin_x86_64

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): From BC3 staging for 5.4.0 release QA

Description of the problem including expected versus actual behavior: There are filters on spy panel in discover!!!

Filtering in for a value works on them. But filtering out does not. As a result you actually get stuck and cannot go back to looking at all values for that index pattern on discover.

Same bug in 5.3.1. So this is not a regression.

Steps to reproduce:

  1. Load Logstash(any time-series data) index pattern and open it in discover
  2. Open spy panel
  3. Click on filtering in on that value which works fine. But when you filter out - it doesn't work. You actually are stuck in there and the only way out is clicking on browser's back button. Also the filter controls don't show up as they do elsewhere when you use them.

filter_out_doesn t_work

@bhavyarm bhavyarm added Feature:Discover Discover Application :Discovery Feature:Filters bug Fixes for quality problems that affect the customer experience labels Apr 27, 2017
@bhavyarm bhavyarm changed the title Filtering out on spy panel doesn't work. Filtering out on spy panel in discover doesn't work. Apr 27, 2017
@Bargs Bargs added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Apr 27, 2017
@Bargs
Copy link
Contributor

Bargs commented Apr 27, 2017

I'm guessing this is due to the changes in #9989. I'm not sure whether we should keep the filter buttons and make them work in the spy panel, or get rid of them from the spy panel.

@lukasolson
Copy link
Member

@Bargs Any reason we wouldn't want to keep them in the spy panel?

@Bargs
Copy link
Contributor

Bargs commented Apr 28, 2017

The only thing I can think of off the top of my head is that more things in the spy panel will be un-filterable, so it might be confusing.

For instance, none of these columns are filterable for the tilemap:

screen shot 2017-04-28 at 1 50 03 pm

It might not be obvious to a user why the filter icons don't show up here, but they do for a timestamp field, for instance. We already hide the filter icon in non-filterable columns so it's not like it'll break anything, but it just might be confusing.

@Bargs
Copy link
Contributor

Bargs commented May 12, 2017

This seems to be working fine now, I think it may have been fixed by #11628

@Bargs Bargs closed this as completed May 12, 2017
@bhavyarm bhavyarm reopened this Jun 30, 2017
@bhavyarm
Copy link
Contributor Author

Reopening this as this isn't working in 5.5.0 BC

@Bargs Bargs added the good first issue low hanging fruit label Aug 4, 2017
@timroes timroes added the Feature:Inspector Inspector infrastructure and implementations label Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Feature:Filters Feature:Inspector Inspector infrastructure and implementations Feature:Visualizations Generic visualization features (in case no more specific feature label is available) good first issue low hanging fruit
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants