Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Improve tick placement for binary formatter #114441

Closed
flash1293 opened this issue Oct 11, 2021 · 2 comments · Fixed by #116158
Closed

[Lens] Improve tick placement for binary formatter #114441

flash1293 opened this issue Oct 11, 2021 · 2 comments · Fixed by #116158
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

With elastic/elastic-charts#1389 elastic-charts added the ability to render ticks taking into account whether they are formatted as binary values or not.

To leverage this functionality in Lens, it's necessary to leverage this information in the xy renderer to choose the LinearBinary scale type instead of Linear.

As there are currently plans in development to rethink the formatting system in Kibana, this should be done by leveraging the mechanism we already have.

If the axis formatter has id: 'bytes' and the yScaleType is "Linear", use "LinearBinary" instead.

@flash1293 flash1293 added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Oct 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

@flash1293
Copy link
Contributor Author

See also #7539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants