Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update add data links to navigate to the unified integrations view #114344

Closed
1 of 5 tasks
Tracked by #93084
alexfrancoeur opened this issue Oct 7, 2021 · 2 comments
Closed
1 of 5 tasks
Tracked by #93084
Labels
Feature:Unified Integrations Unified Integrations view feature needs-team Issues missing a team label v7.16.0 v8.0.0

Comments

@alexfrancoeur
Copy link

alexfrancoeur commented Oct 7, 2021

As part of the migration to the new unified integrations view (#93084), we'll need to make sure all entry points are updated and able to handle Kibana RBAC.

Update "add data" links to navigate to Integrations app instead of "add data" tutorial directory

#94179 (duplicate potentially) @cchaos @snide

  • Welcome interstitial
  • "Add Data" CTA on home page
  • Solution empty data prompts

We should use a locator for this from App Services: https://www.elastic.co/guide/en/kibana/master/kibana-navigation.html#_specifying_state

Disable UI elements if user does not "read" access for the integrations app @thomasneirynck

We have decided that we will disable buttons and entry points with a tooltip to provide context instead updating the empty state to overwrite the default Kibana experience. This will be less confusing for the user (cc: @dborodyansky )

  • Index pattern onboarding flow out-of-scope due to empty-data state for Analyze being at-risk
  • Hide "add data" CTA in navigation (not disable, this happens with fleet RBAC already)

Rename "Add data" to "Add integrations" @cchaos @snide

There is an open discussion around if whether or not we want to update text for our entry point to integrations. This decision still needs to be made for 7.16, but we may defer to future releases.

cc: @mostlyjason @dborodyansky @joshdover @clintandrewhall @thomasneirynck

@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 7, 2021
@alexfrancoeur alexfrancoeur added the Feature:Unified Integrations Unified Integrations view feature label Oct 12, 2021
@thomasneirynck thomasneirynck removed their assignment Oct 13, 2021
@alexfrancoeur
Copy link
Author

@thomasneirynck the original logic we landed on for the integrations page in "view" mode is below:

Users with All or Read Kibana privileges for “Fleet and Integrations” get access to the Integrations app. However, users with custom privileges will not unless it's explicitly added.

If Fleet & Integrations is explicitly disabled through a custom role, we are not seeing the Add data button in the navigation which is expected behavior.

image

A read only role with the following permissions does not hide the button. This is also expected for data discovery purposes.

image

image

image

So to clarify Hide "add data" CTA in navigation (not disable, this happens with fleet RBAC already), I believe we are all set here with the expected behavior and there is no work needed on your end.

I believe the index pattern onboarding flow is still in flight. But if a user does not have any permissions to fleet & integrations, I think we'll need a way to address that in a similar fashion as solutions. I imagine we could just disable the button to add data. It does open a broader question for how we should handle on the homepage as well. RBAC for integrations does not seem to impact that view. @cchaos @ryankeairns @dborodyansky how do you think we should handle those views when there is no access to integrations?

@cchaos
Copy link
Contributor

cchaos commented Oct 13, 2021

Instead of having to change all the places where we link TO tutorial_directory, can we not just have that specific url redirect to integrations? Since that page will eventually be "removed" anyway, this will effectively not break any missed links or any links that may exist outside of the application like in documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Unified Integrations Unified Integrations view feature needs-team Issues missing a team label v7.16.0 v8.0.0
Projects
None yet
Development

No branches or pull requests

4 participants