Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fullstory] Enable reporting when running from source #114328

Closed
lizozom opened this issue Oct 7, 2021 · 4 comments
Closed

[Fullstory] Enable reporting when running from source #114328

lizozom opened this issue Oct 7, 2021 · 4 comments
Assignees
Labels
enhancement New value added to drive a business result Feature:Telemetry impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc telemetry Issues related to the addition of telemetry to a feature v7.16.0 v8.0.0

Comments

@lizozom
Copy link
Contributor

lizozom commented Oct 7, 2021

At the moment, fullstory is enabled and reporting only when running on cloud.
We'd like to leverage fullstory's capabilities to improve our own developer experience.
In order to do that, we want to enable fullstory when running kibana locally in dev mode (!isKibanaDistributable).

Ideas:

  • We need to set an env var to allow user segmentation (dev: true?)
  • Should we move the integration code outside of the cloud plugin?
  • Find out what domain we need to enable on fullstory admin for the data to be recorded
@lizozom lizozom added v8.0.0 reason:enhancement v7.16.0 telemetry Issues related to the addition of telemetry to a feature labels Oct 7, 2021
@lizozom lizozom self-assigned this Oct 7, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 7, 2021
@lizozom lizozom changed the title [Fullstory] enable reporting when running from source [Fullstory] Enable reporting when running from source Oct 13, 2021
@afharo afharo added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Dec 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 17, 2021
@exalate-issue-sync exalate-issue-sync bot added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Mar 1, 2022
@afharo
Copy link
Member

afharo commented Mar 1, 2022

#121992 will already move the piece of logic to a package.

However, don't we need special configuration like the org_id for Fullstory to work?

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Mar 8, 2022
@afharo
Copy link
Member

afharo commented Apr 20, 2022

@lizozom developers can now enable it by setting:

xpack.cloud.id: "elastic_kibana_dev"
xpack.cloud.full_story.enabled: true
xpack.cloud.full_story.org_id: "<FullStory's Org ID>"

Is the request to enable it by default in development mode? I'd like to understand the benefit we'd get if we did that. I wonder if it'd create more noise than anything. I'm thinking about developing a feature and it crashing: those errors will be reported to FullStory even when they are not really that important because the developer is taking care of them as part of their own development cycle & testing.

@lukeelmers
Copy link
Member

I'd like to understand the benefit we'd get if we did that. I wonder if it'd create more noise than anything

++ Agreed, it isn't clear to me what concrete benefits we'd get from doing this, and we'd be using up our FS sessions for it. IMO tools like buildbuddy are better suited to answer questions about the DX in Kibana.

I'm going to go ahead and close this issue for now. If you disagree, feel free to reopen so we can discuss @lizozom

@lukeelmers lukeelmers closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2022
@sophiec20 sophiec20 added the enhancement New value added to drive a business result label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Telemetry impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc telemetry Issues related to the addition of telemetry to a feature v7.16.0 v8.0.0
Projects
None yet
Development

No branches or pull requests

5 participants