Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functional tests for insecure cluster warning #114049

Closed
jportner opened this issue Oct 6, 2021 · 3 comments · Fixed by #136899
Closed

Add functional tests for insecure cluster warning #114049

jportner opened this issue Oct 6, 2021 · 3 comments · Fixed by #136899
Assignees
Labels
chore Feature:Functional Testing impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@jportner
Copy link
Contributor

jportner commented Oct 6, 2021

Starting in 7.16, we got rid of the securityOss plugin, refactoring the insecure cluster warning code in the process.

Before 7.16, the insecure cluster warning could be shown in two different scenarios:

  1. The Kibana security plugin is not available
  2. Kibana security is available, but Elasticsearch security is disabled

After 7.16, scenario 1 is no longer possible, because the code has been moved to the security plugin. If the security plugin is not available, the insecure cluster warning will not be shown at all.

As described in #113946 (comment), we never had functional test coverage for scenario 2, because our functional testing tooling did not support running the Kibana server in that fashion.

Once we have support for that in 8.0, we should add new tests to exercise scenario 2. They will be nearly identical to the tests that are mentioned in the linked comment above.

Blocked by: #54023 <-- this will include the work to change our security functional tests to run with the Kibana security plugin available and Elasticsearch security disabled

@jportner jportner added chore Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Functional Testing labels Oct 6, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Oct 7, 2021
@legrego
Copy link
Member

legrego commented Feb 11, 2022

Potentially unnecessary pending the outcome of #125364

@legrego
Copy link
Member

legrego commented Jul 20, 2022

@kc13greiner if you're feeling ambitious, I think it'd be great to address this issue alongside #116971. You'll probably need some help understanding the functional test runner, but either @azasypkin or I can assist when the time comes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Functional Testing impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants