Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] [Metrics UI] Register deprecations for field configurations #113166

Closed
5 tasks done
Tracked by #113171
jasonrhodes opened this issue Sep 27, 2021 · 3 comments · Fixed by #115103
Closed
5 tasks done
Tracked by #113171

[Logs UI] [Metrics UI] Register deprecations for field configurations #113166

jasonrhodes opened this issue Sep 27, 2021 · 3 comments · Fixed by #115103
Assignees
Labels
Epic: Logs & Metrics 8.0 Plan Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.16.0

Comments

@jasonrhodes
Copy link
Member

jasonrhodes commented Sep 27, 2021

In preparation for #113163 and #113165, we need to use the Deprecations Service to register our deprecations for 7.16 so that a user can view those deprecation notices in the upgrade assistant.

AC:

  • Deprecation instructions appear in the Migration Assistant in the 7.16 branch (not 8.0/master/main) if any of the following fields are set in the user's default source configuration saved object:
    • timestamp
    • tiebreaker
    • host name
    • pod ID
    • container ID
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 27, 2021
@jasonrhodes jasonrhodes added Epic: Logs & Metrics 8.0 Plan Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.16.0 labels Sep 27, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@jasonrhodes
Copy link
Member Author

@Zacqary have you had a chance to look at the deprecations side of this? We need to tackle that ASAP before we worry about removing the code. Let me know if you have a chance to look, and if not, we can chat more about what this looks like.

@Kerry350 Kerry350 assigned Kerry350 and unassigned Kerry350 Oct 14, 2021
@Zacqary
Copy link
Contributor

Zacqary commented Oct 14, 2021

I can set these notices up in the API, but I'm not sure what to add for a documentation link or upgrade steps. The deprecation notice in the Source Configuration screen links to an old documentation page from version 7.4.

What do we want to tell the user to do if they've set any of these values to a non-default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic: Logs & Metrics 8.0 Plan Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.16.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants