Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Encapsulate expression functions using forked service #112859

Closed
dokmic opened this issue Sep 22, 2021 · 2 comments
Closed

[Canvas] Encapsulate expression functions using forked service #112859

dokmic opened this issue Sep 22, 2021 · 2 comments
Labels
Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@dokmic
Copy link
Contributor

dokmic commented Sep 22, 2021

As part of #110841, the fork call has been removed since it's no longer possible to fork the start contract.

The proposed solution is to fork the setup contract and keep the service reference. That should enable registering functions under the forked service and therefore hide them from other plugins.
@dokmic dokmic added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Canvas labels Sep 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@dokmic dokmic mentioned this issue Sep 22, 2021
Merged
3 tasks
@cqliu1 cqliu1 added loe:medium Medium Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Mar 9, 2023
@ThomThomson
Copy link
Contributor

Closing this as we are currently not able to prioritize work that aligns Canvas with the rest of Kibana.

@ThomThomson ThomThomson closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cqliu1 @ThomThomson @dokmic @elasticmachine