[Reporting] Re-introduce tests for Canvas & Dashboard's feature declarations when Reporting disables access-by-role

[tsullivan]

Reporting configuration is being removed from the functional test server in order to run the tests entirely using reporting's defaults. This means tests with Reporting code that is not yet default needs to be shifted to another test suite.

x-pack/test/reporting_api_integration/reporting_and_security/
This has Reporting API Integration tests that enable feature application controls for Reporting enabled. In this suite of tests, we need to add tests for the APIs that are affected:

• Licensing, upgrade and downgrade (x-pack/test/api_integration/apis/security/license_downgrade.ts)
• Application feature capabilities (x-pack/test/api_integration/apis/security/privileges.ts)

x-pack/test/reporting_functional/reporting_and_security/
This has Reporting UI Functional tests that enable feature application controls for Reporting. This suite should have tests that verify the app integration touchpoints that are affected by the setting. (Example: x-pack/test/functional/apps/canvas/reports.ts)

[elasticmachine]

Pinging @elastic/kibana-app-services (Team:AppServices)

[elasticmachine]

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

[LeeDr]

Here's another thought on this. Maybe we let master have the new configuration and appropriate tests while keeping 7.15 (not sure on 7.x) with the current default behavior?
We're generally keeping tests the same on master and 7.x but when the default changes between branches maybe the tests should just change with them only in those branches?

[tsullivan]

I've crossed out the need to re-introduce x-pack/test/api_integration/apis/security/license_downgrade.ts with the non-legacy configuration. But looking again - that test is very specific to security and the existing test that doesn't cover Reporting stuff is fine.

[tsullivan]

I've crossed out the second half of the description because we already have tests that validate the touchpoints of the various applications for users that do/don't have reporting application privilege:

kibana/x-pack/test/reporting_functional/reporting_and_security/security_roles_privileges.ts

Lines 27 to 119 in c6db498

	describe('Dashboard: Download CSV file', () => {
	it('does not allow user that does not have reporting privileges', async () => {
	await reportingFunctional.loginDataAnalyst();
	await reportingFunctional.openSavedDashboard(DASHBOARD_TITLE);
	await reportingFunctional.tryDashboardDownloadCsvNotAvailable('Ecommerce Data');
	});
	it('does allow user with reporting privileges', async () => {
	await reportingFunctional.loginReportingUser();
	await reportingFunctional.openSavedDashboard(DASHBOARD_TITLE);
	await reportingFunctional.tryDashboardDownloadCsvSuccess('Ecommerce Data');
	});
	});
	describe('Dashboard: Generate Screenshot', () => {
	it('does not allow user that does not have reporting privileges', async () => {
	await reportingFunctional.loginDataAnalyst();
	await reportingFunctional.openSavedDashboard(DASHBOARD_TITLE);
	await reportingFunctional.tryReportsNotAvailable();
	});
	it('does allow PDF generation user with reporting privileges', async () => {
	await reportingFunctional.loginReportingUser();
	await reportingFunctional.openSavedDashboard(DASHBOARD_TITLE);
	await reportingFunctional.tryGeneratePdfSuccess();
	});
	it('does allow PNG generation user with reporting privileges', async () => {
	await reportingFunctional.loginReportingUser();
	await reportingFunctional.openSavedDashboard(DASHBOARD_TITLE);
	await reportingFunctional.tryGeneratePngSuccess();
	});
	});
	describe('Discover: Generate CSV', () => {
	it('does not allow user that does not have reporting privileges', async () => {
	await reportingFunctional.loginDataAnalyst();
	await reportingFunctional.openSavedSearch(SAVEDSEARCH_TITLE);
	await reportingFunctional.tryDiscoverCsvNotAvailable();
	});
	it('does allow user with reporting privileges', async () => {
	await reportingFunctional.loginReportingUser();
	await reportingFunctional.openSavedSearch(SAVEDSEARCH_TITLE);
	await reportingFunctional.tryDiscoverCsvSuccess();
	});
	});
	describe('Canvas: Generate PDF', () => {
	const esArchiver = getService('esArchiver');
	const reportingApi = getService('reportingAPI');
	before('initialize tests', async () => {
	await esArchiver.load('x-pack/test/functional/es_archives/canvas/reports');
	});
	after('teardown tests', async () => {
	await esArchiver.unload('x-pack/test/functional/es_archives/canvas/reports');
	await reportingApi.deleteAllReports();
	await reportingFunctional.initEcommerce();
	});
	it('does not allow user that does not have reporting privileges', async () => {
	await reportingFunctional.loginDataAnalyst();
	await reportingFunctional.openCanvasWorkpad(CANVAS_TITLE);
	await reportingFunctional.tryGeneratePdfNotAvailable();
	});
	it('does allow user with reporting privileges', async () => {
	await reportingFunctional.loginReportingUser();
	await reportingFunctional.openCanvasWorkpad(CANVAS_TITLE);
	await reportingFunctional.tryGeneratePdfSuccess();
	});
	});
	describe('Visualize Editor: Generate Screenshot', () => {
	it('does not allow user that does not have reporting privileges', async () => {
	await reportingFunctional.loginDataAnalyst();
	await reportingFunctional.openSavedVisualization(VIS_TITLE);
	await reportingFunctional.tryReportsNotAvailable();
	});
	it('does allow PDF generation user with reporting privileges', async () => {
	await reportingFunctional.loginReportingUser();
	await reportingFunctional.openSavedVisualization(VIS_TITLE);
	await reportingFunctional.tryGeneratePdfSuccess();
	});
	it('does allow PNG generation user with reporting privileges', async () => {
	await reportingFunctional.loginReportingUser();
	await reportingFunctional.openSavedVisualization(VIS_TITLE);
	await reportingFunctional.tryGeneratePngSuccess();
	});
	});

[tsullivan]

Fix on the way: #117443