Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring][Angular removal] Add alerts to react app #111774

Closed
Tracked by #111309
estermv opened this issue Sep 9, 2021 · 1 comment · Fixed by #114029
Closed
Tracked by #111309

[Stack Monitoring][Angular removal] Add alerts to react app #111774

estermv opened this issue Sep 9, 2021 · 1 comment · Fixed by #114029
Assignees
Labels
Epic: Stack Monitoring de-angularization Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@estermv
Copy link
Contributor

estermv commented Sep 9, 2021

Add all alerts related features to the react app for stack monitoring:

  • Modal is shown when entering a page.
  • Navbar button
  • Badge in setup mode to configure alerts
  • Badge that appears when an alert is active

Technical notes

  • There is already a context that that shares the alerts with react child components.
  • Alerts are fetched in the base_controller when a flag should_fetch is set to true from child controllers (like happens here)

As a first implementation, we can have a similar approach and add the same provider to the page_template and receive a boolean prop to indicate when to fetch alerts.

Note that alerts are fetched in each refresh interval, so the request needs to be added to the onRefresh callback in the page_template

@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 9, 2021
@estermv estermv added Epic: Stack Monitoring de-angularization Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Sep 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 9, 2021
@estermv estermv changed the title [Stack Monitoring] Add alerts to react app [Stack Monitoring][Angular removal] Add alerts to react app Sep 9, 2021
@estermv estermv assigned estermv and simianhacker and unassigned estermv Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic: Stack Monitoring de-angularization Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants