Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose an API from chrome service to access the height of the top banner #111688

Open
pgayvallet opened this issue Sep 9, 2021 · 1 comment
Open

Expose an API from chrome service to access the height of the top banner #111688

pgayvallet opened this issue Sep 9, 2021 · 1 comment
Labels
Feature:Header Work related to the header section of the Kibana app. old Used to help sort old issues on GH Projects which don't support the Created search term. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@pgayvallet
Copy link
Contributor

When css is not enough (such as in #111038), the height of the banner needs to be accessed in javascript. We currently only expose this variable from our sass mixins. We need to expose an API from the chrome service (or a constant from the public bundle) to allow consumers to retrieve this value
@pgayvallet pgayvallet added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Header Work related to the header section of the Kibana app. labels Sep 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@pgayvallet pgayvallet mentioned this issue Sep 9, 2021
Merged
4 tasks
@afharo afharo added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Dec 19, 2022
@petrklapka petrklapka added the old Used to help sort old issues on GH Projects which don't support the Created search term. label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Header Work related to the header section of the Kibana app. old Used to help sort old issues on GH Projects which don't support the Created search term. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pgayvallet @afharo @elasticmachine @petrklapka