Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Upgrade Assistant] Remove duplicate EuiScreenReaderOnly from stats component #111477

Closed
alisonelizabeth opened this issue Sep 8, 2021 · 2 comments
Closed

[Upgrade Assistant] Remove duplicate EuiScreenReaderOnly from stats component #111477

alisonelizabeth opened this issue Sep 8, 2021 · 2 comments
Assignees
@sabarasaba
Labels
chore Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@alisonelizabeth
Copy link
Contributor

I noticed while debugging some CITs that EuiScreenReaderOnly is getting rendered twice for the deprecation stat panels.

Screen Shot 2021-09-07 at 8 42 42 PM

Screen Shot 2021-09-07 at 8 42 52 PM

Per the EuiStat code, it looks like this is handled automatically if string values are provided for title and description and we can remove it from our code (here and here).
@alisonelizabeth alisonelizabeth added chore Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Upgrade Assistant labels Sep 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@sabarasaba sabarasaba mentioned this issue Sep 8, 2021
Merged
@sabarasaba
Copy link
Member

Fixed with #111518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sabarasaba sabarasaba

Labels
chore Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sabarasaba @alisonelizabeth @elasticmachine