Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger Server Counters usage API whenever a deprecation is triggered #110618

Closed
3 tasks
afharo opened this issue Aug 31, 2021 · 5 comments
Closed
3 tasks

Trigger Server Counters usage API whenever a deprecation is triggered #110618

afharo opened this issue Aug 31, 2021 · 5 comments
Labels
deprecation_warnings Feature:Telemetry impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@afharo
Copy link
Member

afharo commented Aug 31, 2021

Describe the feature:
In order to help us with identifying when deprecated features are no longer used, it would be interesting to know how many times each deprecation warning is triggered.

A hook and a usage collector could help with this.

Describe a specific use case for the feature:
We may want to track deprecation notifications for

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc deprecation_warnings Team:KibanaTelemetry labels Aug 31, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

@pgayvallet
Copy link
Contributor

We may want to track deprecation notifications for

HTTP Headers

It's more tracking the hits on any deprecated HTTP endpoint, right? This totally makes sense to me.

Ideally, we should automate this from core once we're allowed to flag an API as deprecated.

Configuration

You mean everytime a config value is accessed? That may be very tricky, especially because some props are exposed to the browser, where it would be very hard to track (but even on the server, it's far from trivial)

Other plugin APIs

This one can't probably be automated, to having an API for plugin owners to manually call probably makes sense.

@afharo
Copy link
Member Author

afharo commented Sep 2, 2021

You mean everytime a config value is accessed? That may be very tricky, especially because some props are exposed to the browser, where it would be very hard to track (but even on the server, it's far from trivial)

I was thinking more about when logging a deprecated config item.

We could, probably, put it together to the Other plugin APIs bit. Core could provide a deprecation log, and we could emit an event for every log entry to that logger?

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Nov 4, 2021
@lukeelmers
Copy link
Member

With existing deprecation logs & with the possibility of future event based telemetry, we don't think this issue is needed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation_warnings Feature:Telemetry impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

4 participants