Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Display k8 daemonset yaml in standalone mode #110408

Open
mukeshelastic opened this issue Aug 27, 2021 · 7 comments
Open

[Fleet] Display k8 daemonset yaml in standalone mode #110408

mukeshelastic opened this issue Aug 27, 2021 · 7 comments
Labels
enhancement New value added to drive a business result Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@mukeshelastic
Copy link

In the add agent flyout, if a K8s integration is detected then the standalone mode policy should be the K8s daemonset manifest and not general agent policy and the instructions to install agent should be the kubelet apply -f filename.yaml and not ./elastic-agent install.

Screen Shot 2021-08-27 at 12 49 10 PM

Screen Shot 2021-08-27 at 12 49 29 PM

@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 27, 2021
@mukeshelastic mukeshelastic added the Feature:Fleet Fleet team's agent central management project label Aug 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Feature:Fleet)

@mukeshelastic mukeshelastic removed the needs-team Issues missing a team label label Aug 29, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 29, 2021
@mukeshelastic
Copy link
Author

@ChrsMark fyi

@jen-huang jen-huang added Team:Fleet Team label for Observability Data Collection Fleet team and removed Feature:Fleet Fleet team's agent central management project labels Aug 30, 2021
@botelastic botelastic bot removed the needs-team Issues missing a team label label Aug 30, 2021
@jen-huang
Copy link
Contributor

@mukeshelastic Does this differ from #92113?

@mukeshelastic
Copy link
Author

It does differ but just by a little bit.

This issue relates to add-agent flyout->standalone tab to show K8s daemonset yaml as opposed to the usual agent policy yaml.

#92113 is about fleet mode to show K8s as a platform in the dropdown, for agent policies with K8s integration, making K8s platform as a default choice, including the fleet enrollment token in the daemonset yaml and then install command to be kubectl apply -f daemonset_config.yaml and option to download that file..

There is definitely different work involved in these two issues hence I created them separately but may make sense to do it together to get it all done with single attempt.

@david-kow
Copy link

Should we also be providing ECK Agent resource manifest to achieve the same?

@joshdover joshdover added the enhancement New value added to drive a business result label Sep 7, 2021
@ChrsMark
Copy link
Member

Should we also be providing ECK Agent resource manifest to achieve the same?

It could be an option. We could have 3 tabs like standalone|kubernetes raw|kubernetes eck. I'm not quite sure how easy it would be to combine upstream's manifests and fleet's policies but this should be the way to go so as to be in sync with the source of k8s manifests we maintain. @david-kow do you have any similar upstream files for eck managed Agent?

@david-kow
Copy link

I do like the idea of including ECK as an option there.

We maintain (ie. test them as part of our E2E tests) a number of recipes. They are also exposed in our docs for standalone and fleet modes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

6 participants