Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack monitoring] Angular migration clean-up #109791

Closed
8 tasks done
Tracked by #115024
estermv opened this issue Aug 24, 2021 · 6 comments
Closed
8 tasks done
Tracked by #115024

[Stack monitoring] Angular migration clean-up #109791

estermv opened this issue Aug 24, 2021 · 6 comments
Assignees
Labels
Epic: Stack Monitoring de-angularization Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services technical debt Improvement of the software architecture and operational architecture

Comments

@estermv
Copy link
Contributor

estermv commented Aug 24, 2021

⚠️ DEPENDS ON: #111309

Required to clean to remove angular app from Stack Monitoring

Required to remove Angular from package.json

After angular is removed

@estermv estermv added technical debt Improvement of the software architecture and operational architecture Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Feature:Stack Monitoring Epic: Stack Monitoring de-angularization labels Aug 24, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@matschaffer
Copy link
Contributor

I moved the flag removal to #115504

@matschaffer
Copy link
Contributor

Also moved the setup mode refactor/test points to #112512

@estermv
Copy link
Contributor Author

estermv commented Oct 19, 2021

@matschaffer I moved the refactor/test points back here. What is mentioned in this issue regarding the setup mode should be cleaned now unless there is a major reason to not do it. It should be quick and easy. (I was planning to finish the remaining bullet points between today and tomorrow 😅 )

The refactor setup mode task that was in the tech debt issue is to rewrite how the setup mode is implemented, because, in my opinion, the way it's currently implemented is complex and confusing probably because of the mix of Angular and React.

@matschaffer
Copy link
Contributor

@estermv - cool. I'll leave it in your hands then. Seems like we might be done as far as upstream is concerned but you probably know better than I do.

@estermv estermv changed the title [Stack monitoring] Remove Angular [Stack monitoring] Angular migration clean-up Oct 20, 2021
@estermv
Copy link
Contributor Author

estermv commented Oct 21, 2021

Closing this as all tasks have been completed.

@estermv estermv closed this as completed Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic: Stack Monitoring de-angularization Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

4 participants