-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for Filtering the Log Context View #10954
Comments
I do like solution 4 as it gives the user a possibility to use the feature without having to change their data. While this makes it very convenient it requires that first step of configuring a filter set. Workflow 3 can be a little confusing if we mix it with saved searches, but I can also see the benefits of it, since it adds a lot of possibilities. I would still say to keep it simple and have dedicated filter definitions on the index pattern. In any case modifying the filters after switching should also be supported (candidate #3) so I can filter down if I don't have a filter set or if I want to modify my filters. |
@LucaWintergerst, thank you for that feedback! I would be interested to also hear your opinion regarding the choice between variations D1/D2 or D4/D5 of solution candidate 4. D1 and D4 propose to store the filter sets per index pattern while D2 and D5 posit the saved search as the place to define and store the filter sets. From your experience, how heavy would the following argument weigh for you?
|
My first thought was that using saved searches makes it confusing, unless we can filter by type. E.g. there will be regular saved searches and filter sets. Something that would be nice to have would be filter sets across index patterns. If I just had to decide between index pattern and saved search, I would go with the index pattern. Defining a filter set is much different from defining a filter as part of a saved search. The user would probably get confused if it is part of the same Does that make sense? |
The con you listed for D1 |
You could "re-use/copy" a filter set definition from one saved search to the other by loading the search, changing the index pattern and re-saving under a new name. But that feels more like a workaround too. Index patterns really seem to be the best location so far. Thanks again for the input! |
You are right, changing index patterns does work for searches. I was not aware of this until now. I suppose that top level filter sets (for all patterns) require too many changes, as it would be easier to just tie them to either search or index patterns? |
Introducing a new top-level concept could be quite an effort, yes. But more importantly, it could be pretty difficult to find a user workflow that is easy to understand and perform. More freedom often means a more complex UI with more potential for misunderstanding and confusion (e.g. applying the filters to index patterns that don't have the required fields). Restricting the scope allows for more guidance and sanity checking by the application. |
Note: This is a summary of the exploration and evaluation that is documented in weltenwort/kibana-plan-context-filter. It expands the work started in #9198 to fulfill a broader set of needs such as those described in the comments if #275.
Problem Statement
Centralized logging with Elasticsearch and Kibana is particularly valuable for large amounts of log data from numerous sources. For large amounts of log entries however, the current context view as implemented in #9198 loses most of its usefulness, because log entries not related to the anchor entry swamp the relevant entries in the context.
Discussion
The concept of the context view is to loosen the potentially very narrow filters used to find a particular event in the Discover view to allow for a broader inspection of the "relevant" events in the system immediately leading up to (or following) the event. This misleadingly suggests that the latter set of filters is a subset of the former, which might not even be the case in most circumstances. Another, maybe less misleading formulation would be that we want to provide a way for the user to tell Kibana what makes up the "relevant context" for the event so Kibana. So far the context view only uses adjacency in time as a criterion.
To summarize some observations about the two sets of filters:
Abstract Formulation
It should be possible to limit the entries shown in the context view to those "relevant" to the event the user is inspecting. This translates to the ability to apply filters to the context view that are different from the filters used to identify the original log entry.
Concrete Solution Proposal
The text was updated successfully, but these errors were encountered: