Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to HTTPS when SSL is enabled #10948

Closed
tylersmalley opened this issue Mar 29, 2017 · 4 comments
Closed

Redirect to HTTPS when SSL is enabled #10948

tylersmalley opened this issue Mar 29, 2017 · 4 comments
Assignees
Labels
release_note:enhancement Team:Operations Team label for Operations Team

Comments

@tylersmalley
Copy link
Contributor

Previously we were using httpolyglot to serve multiple protocols over the same port, which resulted in choosing to remove it.

This feature is for those who are exposing the server directly, otherwise, it would make more sense to handle the SSL termination and redirection at the load-balancer.

The currently proposed solution would be to automatically bind to port 80 if server.ssl.enabled is true and server.port is set to 443. Allowing us to redirect traffic from http://${server.host} to https://${server.host}.

A concern with this approach is the assumption that there is nothing else binding to port 80. It's possible to gracefully handle this scenario. Alternatively, we could provide configuration to override this port or disable the redirection/binding entirely.

@tylersmalley
Copy link
Contributor Author

@epixa - I am having a hard time thinking of a reason why you would want the redirect to happen on a port other than 80/443 so I excluded my suggestion of providing server.httpPort and server.httpsPort

@jbudz
Copy link
Member

jbudz commented Mar 30, 2017

In on redirects but I'm iffy on the approach. As a server admin I would want to know exactly what my configuration is doing, and autobinding when 443 would involve some magic that would be unexpected for me.

Taking the concern a step further, although unlikely, what if on restart kibana beats that service to port 80? No problem if I explicitly said redirect port 80, but if it's automatically happening it could cause some confusion.

@epixa
Copy link
Contributor

epixa commented Mar 30, 2017

You've convinced me with that startup scenario. How about a redirectFromPort80 configuration flag for ssl?

@kimjoar kimjoar self-assigned this Jul 6, 2017
@jbudz
Copy link
Member

jbudz commented Jul 18, 2017

Closed by #10930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:enhancement Team:Operations Team label for Operations Team
Projects
None yet
Development

No branches or pull requests

4 participants