-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Add link to documentation for Alert Notification Placeholders/Examples in Actions UI #108940
Comments
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Please view the proposed design screens for this request, attaching the Figma mock link for design details:
|
Nice update on this! Is there a better title for the popover? Are these simply Would it make sense to break out templates as a separate menu? (Then I think you'll definitely want labels next to the icons) Also, we will likely want to transition this to the markdown editor so we can gain the benefits of that component similar to how we have it in Cases. Something to consider if you're spending a fair amount of time on this. |
Great stuff @yiyangliu9286, thanks for sharing! 🙂 And @mdefazio, I think I believe the @elastic/kibana-alerting-services team owns this portion of the UI currently, so they might be able to chime in on some history here or relevant issues with regards to upgrading the editor. |
The code lives within the platform plugin, but is open for anyone to enhance. We've tracked some requests to use EUI Markdown editor such as the email body, but enhancing generic components (textareas to become markdown editors) comes with caveats if we want to support rich text. We've discovered each connector implements a slightly different version of markdown and can be tricky to get right (#87440, #79371 (comment)) making the switch to EUI Markdown editor a bit more complex than a simple swap. |
Thanks for the feedback @mdefazio & @spong!
|
@yiyangliu9286 @spong does it still require some design work? |
I think we still need a final review of this design and buyoff from the alerting folks if we're planning more structural changes of this shared component. Probably fine to wire up an override for the title ( Security Flow: Stack Mgmt Flow: |
@peluja1012 please create a separate ticket for UX improvements |
Additional community request that would benefit from inline examples/documentation outlined here. |
We've received a number of questions around the format and available options for constructing the
message
within Action UI when creating/editing Rules. This enhancement is for adding a docs link within the UI so users can better understand their options and proper formatting necessary to achieve their use case. In addition to a docs link, we could also add atemplate
selector that could be pre-populated with popular templates per rule type or other use cases -- defer to @elastic/security-design on any additional UX enhancements outside of the docs link.Useful Docs Links:
Figma mock link for designs
The text was updated successfully, but these errors were encountered: