Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Add link to documentation for Alert Notification Placeholders/Examples in Actions UI #108940

Open
spong opened this issue Aug 17, 2021 · 11 comments
Labels
enhancement New value added to drive a business result Feature:Rule Actions Security Solution Detection Rule Actions area Feature:Rule Creation Security Solution Detection Rule Creation workflow needs design Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Theme: simp_prot_mgmt Security Solution Simplified Protection Management Theme UX Debt

Comments

@spong
Copy link
Member

spong commented Aug 17, 2021

We've received a number of questions around the format and available options for constructing the message within Action UI when creating/editing Rules. This enhancement is for adding a docs link within the UI so users can better understand their options and proper formatting necessary to achieve their use case. In addition to a docs link, we could also add a template selector that could be pre-populated with popular templates per rule type or other use cases -- defer to @elastic/security-design on any additional UX enhancements outside of the docs link.

Useful Docs Links:

Figma mock link for designs

@spong spong added triage_needed enhancement New value added to drive a business result Feature:Detection Rules Security Solution rules and Detection Engine Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Actions Security Solution Detection Rule Actions area labels Aug 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@yiyangliu9286
Copy link

Please view the proposed design screens for this request, attaching the Figma mock link for design details:

  • Based on the requirement, adding a docs link button so users can have more context around their options and proper formatting necessary to achieve their use case.

Edit rule settings_Actions

  • Proposing a new Popover design for "Alert notifications placeholders" for showing the pre-populated template selector (open to feedback for what we call this template selector)
  • Adding a search functionality for users to quickly search for the templates.
  • Adding a Rule type templates as a sub menu option.

Edit rule settings_Actions_Popover

  • For the Rule type templates submenu, adding pre-populated templates based on the rule type, also proposing to add search functionality here to enhance the usability as well.
  • Question for this: Other than the Threadhold rule template that I am seeing in this doc link, are there any other examples / templates for other rule types other than Threashold rule? (cc: @spong @peluja1012 @jethr0null)

Edit rule settings_Actions_Popover_Nested

@mdefazio
Copy link
Contributor

Nice update on this!

Is there a better title for the popover? Are these simply Alert variables? Or perhaps we should add in the label next to the icon and then we might not need the popover title.

Would it make sense to break out templates as a separate menu? (Then I think you'll definitely want labels next to the icons)

Also, we will likely want to transition this to the markdown editor so we can gain the benefits of that component similar to how we have it in Cases. Something to consider if you're spending a fair amount of time on this.

@spong
Copy link
Member Author

spong commented Sep 14, 2021

Great stuff @yiyangliu9286, thanks for sharing! 🙂 And @mdefazio, I think Alert variables would work well here. ++ to using the markdown editor as well if we can (along with any auto-complete we can provide).

I believe the @elastic/kibana-alerting-services team owns this portion of the UI currently, so they might be able to chime in on some history here or relevant issues with regards to upgrading the editor.

@mikecote
Copy link
Contributor

I believe the @elastic/kibana-alerting-services team owns this portion of the UI currently, so they might be able to chime in on some history here or relevant issues with regards to upgrading the editor.

The code lives within the platform plugin, but is open for anyone to enhance. We've tracked some requests to use EUI Markdown editor such as the email body, but enhancing generic components (textareas to become markdown editors) comes with caveats if we want to support rich text. We've discovered each connector implements a slightly different version of markdown and can be tricky to get right (#87440, #79371 (comment)) making the switch to EUI Markdown editor a bit more complex than a simple swap.

@yiyangliu9286
Copy link

Thanks for the feedback @mdefazio & @spong!

  1. Attaching a short-term revised vision IF we decided to still go for the existing component with the Popover I proposed in the first iteration:
  • I have updated some UX/UI problems I saw in this current page layout (figma) re: depaneling the page, update "Actions" header to "Connectors" to make it less repetitive, remove the "add templates" icons and replaced it to buttons with labels to call out Alert variables and Rule variables also removing some of the button placements to make the experience more intuitive.

Edit rule settings_Connectors

  • Alert variables Popover

Edit rule settings_Alert variables popover

  • Rule variables Popover

Edit rule settings_Rule variables popover

  1. IF we'd like to use Markdown Editor, I have thought about a possible view may look like this (but it looks like a more long-term vision):

Edit rule settings_Connectors

@peluja1012 peluja1012 added Theme: simp_prot_mgmt Security Solution Simplified Protection Management Theme and removed triage_needed labels Oct 26, 2021
@banderror
Copy link
Contributor

@yiyangliu9286 @spong does it still require some design work?

@spong
Copy link
Member Author

spong commented Nov 24, 2021

I think we still need a final review of this design and buyoff from the alerting folks if we're planning more structural changes of this shared component. Probably fine to wire up an override for the title (Actions->Connectors section) for security, but I'm not entirely sure how the + Connector button fits into the existing workflow of selecting a connector and creating if it doesn't exist -- so need some clarity here. But I think we're fine with adding the Alert/Rule variables components as optional props and so Security can add whatever we need without changing it for Stack.

Security Flow:

Stack Mgmt Flow:

@banderror
Copy link
Contributor

@peluja1012 please create a separate ticket for UX improvements

@spong
Copy link
Member Author

spong commented Jan 13, 2022

Additional community request that would benefit from inline examples/documentation outlined here.

@banderror banderror added 8.2 candidate considered, but not committed, for 8.2 release and removed v8.1.0 labels Feb 14, 2022
@banderror banderror added 8.3 candidate and removed v8.2.0 8.2 candidate considered, but not committed, for 8.2 release labels Apr 11, 2022
@banderror banderror added Team:Detection Alerts Security Detection Alerts Area Team Feature:Rule Creation Security Solution Detection Rule Creation workflow and removed Feature:Detection Rules Security Solution rules and Detection Engine Team:Detection Rule Management Security Detection Rule Management Team labels Oct 25, 2022
@banderror banderror changed the title [Security Solution][Detections] Add link to documentation for Alert Notification Placeholders/Examples in Actions UI [Security Solution] Add link to documentation for Alert Notification Placeholders/Examples in Actions UI Oct 25, 2022
@yctercero yctercero added Team:Detection Engine Security Solution Detection Engine Area and removed Team:Detection Alerts Security Detection Alerts Area Team labels May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Rule Actions Security Solution Detection Rule Actions area Feature:Rule Creation Security Solution Detection Rule Creation workflow needs design Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Theme: simp_prot_mgmt Security Solution Simplified Protection Management Theme UX Debt
Projects
None yet
Development

No branches or pull requests

8 participants