Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAC] Observability Alerts table view: fix header component and inspect icon #108832

Closed
katrin-freihofner opened this issue Aug 17, 2021 · 2 comments
Closed

[RAC] Observability Alerts table view: fix header component and inspect icon #108832

katrin-freihofner opened this issue Aug 17, 2021 · 2 comments
Assignees
@afgomez
Labels
bug Fixes for quality problems that affect the customer experience Team:Observability Team label for Observability Team (for things that are handled across all of observability) Theme: rac label obsolete

Comments

@katrin-freihofner
Copy link
Contributor

katrin-freihofner commented Aug 17, 2021 •
edited
Loading

We need to fix the alignment of the inspect icon. I think we should check if the title is there and not empty and render the header depending on that.

Current status
inspect

Goal
https://github.com/elastic/observability-design/issues/83#issuecomment-898400943
image

Originally posted by @katrin-freihofner in #108507 (comment)
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 17, 2021
@katrin-freihofner katrin-freihofner added Theme: rac label obsolete bug Fixes for quality problems that affect the customer experience labels Aug 17, 2021
@afgomez afgomez self-assigned this Aug 25, 2021
@vadimkibana vadimkibana added Team:Observability Team label for Observability Team (for things that are handled across all of observability) and removed needs-team Issues missing a team label labels Sep 3, 2021
@afgomez
Copy link
Contributor

afgomez commented Sep 3, 2021

@katrin-freihofner I cannot reproduce the broken button. I tried in Firefox (screenshot), Chrome and Safari.

Screenshot 2021-09-03 at 12 34 53

We still need to move the "Updated at" label, but that was already tracked in another issue.

@katrin-freihofner
Copy link
Contributor Author

@katrin-freihofner I cannot reproduce the broken button. I tried in Firefox (screenshot), Chrome and Safari.

@afgomez thank you, it seems to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afgomez afgomez

Labels
bug Fixes for quality problems that affect the customer experience Team:Observability Team label for Observability Team (for things that are handled across all of observability) Theme: rac label obsolete
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@afgomez @katrin-freihofner @vadimkibana