Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Allow App State Modifications Via URL #108548

Closed
ThomThomson opened this issue Aug 13, 2021 · 1 comment · Fixed by #109354
Closed

[Dashboard] Allow App State Modifications Via URL #108548

ThomThomson opened this issue Aug 13, 2021 · 1 comment · Fixed by #109354
Labels
Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

When is Dashboard state read from URL

After #97941, in 7.14.0, dashboard state is only read and updated from the URL once on app load. The state is then removed from the URL and backed up in the session storage and redux state.

Some use cases, like #108433 (comment) require app state to be modified programatically at runtime by injecting variables into the URL. Before 7.14, these runtime state updates would be applied, after 7.14, modifying the URL without a hard refresh does not apply the state.

A possible solution
A subscription could be added which listens for changes from the app state in the URL, and overrides any state in the session storage & redux with the values injected via the URL. The _a param would subsequently be removed from the URL again, to keep the address bar clean. This would be possible in the new dashboard state architecture, and would allow programatic change of the entire dashboard state.

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Aug 13, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants