Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[canvas] expressions should be migrated and references extracted/injected #107494

Closed
ppisljar opened this issue Aug 3, 2021 · 2 comments
Closed

[canvas] expressions should be migrated and references extracted/injected #107494

ppisljar opened this issue Aug 3, 2021 · 2 comments
Labels
Feature:Canvas Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ppisljar
Copy link
Member

ppisljar commented Aug 3, 2021

Canvas is storing expression string in its saved objects. In order to guarantee future compatibility it should run migration on those expressions and extract references in top level references key inside the saved object.
@ppisljar ppisljar added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Aug 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ppisljar ppisljar added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Aug 3, 2021
@cqliu1 cqliu1 changed the title [canvas] expressions should be mirated and references extracted/injected [canvas] expressions should be migrated and references extracted/injected Mar 9, 2023
@cqliu1
Copy link
Contributor

cqliu1 commented Mar 9, 2023

Embeddables in Canvas are migratable now as of #123515.

@cqliu1 cqliu1 closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Canvas Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cqliu1 @marius-dr @ppisljar @elasticmachine