Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging for failed migrations #107288

Closed
mshustov opened this issue Jul 30, 2021 · 1 comment · Fixed by #108213
Closed

Improve logging for failed migrations #107288

mshustov opened this issue Jul 30, 2021 · 1 comment · Fixed by #108213
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@mshustov
Copy link
Contributor

If migrations v2 failed due to an Elasticsearch response with an empty body (413 error, for example), the log record emitted by SavedObject service won't provide any information about the root cause:

{"ecs":{"version":"1.9.0"},"@timestamp":"2021-07-30T08:17:14.548-04:00","message":"[.kibana] [undefined]: Response Error","log":{"level":"ERROR","logger":"savedobjects-service"},"process":{"pid":45967}}

Run node scripts/jest_integration src/core/server/saved_objects/migrationsv2/integration_tests/migration.test.ts on this branch to reproduce the problem.
We could improve logging by extending the log record with response meta-data: status code, URL. See what we log on the Elasticsearch service level https://github.com/mshustov/kibana/blob/f47c89f52431b56005701bffbae0cfa591413d19/src/core/server/elasticsearch/client/configure_client.ts#L70

@mshustov mshustov added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc enhancement New value added to drive a business result labels Jul 30, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants