Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace appBasePath usage with the history property of AppMountParameters #107254

Closed
tsullivan opened this issue Jul 30, 2021 · 3 comments
Closed

Replace appBasePath usage with the history property of AppMountParameters #107254

tsullivan opened this issue Jul 30, 2021 · 3 comments
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture v8.0.0

Comments

@tsullivan
Copy link
Member

Kibana version: 7.7+

In #56705, the core team updated the AppMountParameters interface by adding a history property and deprecating appBasePath.

Now that appBasePath is deprecated, it needs to be removed from usage in the code.

https://github.com/elastic/kibana/blob/a2c002d/docs/development/core/public/kibana-plugin-core-public.appmountparameters.appbasepath.md
@tsullivan tsullivan added bug Fixes for quality problems that affect the customer experience blocker v8.0.0 labels Jul 30, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 30, 2021
@tsullivan tsullivan added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Jul 30, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 30, 2021
@tsullivan
Copy link
Member Author

@elastic/kibana-core I am not sure which version the appBasePath property is planned to be removed. I added the 8.0 label, but feel free to change it.

@tsullivan tsullivan mentioned this issue Jul 30, 2021
Merged
1 task
@mshustov mshustov mentioned this issue Aug 19, 2021
Closed
@pgayvallet pgayvallet added technical debt Improvement of the software architecture and operational architecture and removed bug Fixes for quality problems that affect the customer experience blocker labels Feb 17, 2022
@pgayvallet
Copy link
Contributor

recategorizing from bug to tech debt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture v8.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tsullivan @pgayvallet @TinaHeiligers @elasticmachine