Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Table Cell Color Opacity Not Taken Into Account #106593

Closed
MichaelMarcialis opened this issue Jul 22, 2021 · 2 comments · Fixed by #107877
Closed

[Lens] Table Cell Color Opacity Not Taken Into Account #106593

MichaelMarcialis opened this issue Jul 22, 2021 · 2 comments · Fixed by #107877
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@MichaelMarcialis
Copy link
Contributor

Kibana version:
8.0.0

Elasticsearch version:
8.0.0-SNAPSHOT

Server OS version:
macOS 11.4

Browser version:
Chrome 91.0.4472.164

Browser OS version:
macOS 11.4

Original install method (e.g. download page, yum, from source, etc.):
From source

Describe the bug:
When applying a cell background color to a Lens table visualization, a check is performed to apply a text color that has the best contrast ratio against that background color. Unfortunately it appears that opacity is not taken into account during that check, which can yield unexpected outcomes in both light and dark modes.

For example, if using a dark color with a very low opacity in light mode, the text can become nearly invisible. Similarly, if using a light color with a very low opacity in dark mode, the text will also become nearly invisible.

Steps to reproduce:

  1. Turn on dark mode in Advanced Settings.
  2. Create a table visualization in Lens.
  3. Edit the color.
  4. Reduce the opacity of the first color stop to zero.
  5. The resulting change will render the text of cells using that color nearly unreadable.

Expected behavior:
In addition to the cell background color, I think we need to also take into account both the opacity of that color and whether the user is in light/dark mode to make the correct choice of table cell text color to apply.

Screenshots (if relevant):
image

CCing @ghudgins

@MichaelMarcialis MichaelMarcialis added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jul 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula stratoula added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Jul 26, 2021
@ghudgins ghudgins added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Aug 1, 2021
@ghudgins
Copy link
Contributor

ghudgins commented Aug 1, 2021

@stratoula I increased the impact & priority of this since, best I can tell, there's no workaround

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants