Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] make data table selectable #106436

Closed
Tracked by #57709
LeeDr opened this issue Jul 21, 2021 · 7 comments · Fixed by #106982
Closed
Tracked by #57709

[Lens] make data table selectable #106436

LeeDr opened this issue Jul 21, 2021 · 7 comments · Fixed by #106982
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@LeeDr
Copy link

LeeDr commented Jul 21, 2021

Describe the feature: When you use Lens to create a data table, it would be nice to be able to select values from the results with your mouse to copy/paste somewhere. People are used to copying text from anything in a browser to paste somewhere else and expect to be able to. But you can't do it in the Lens Data Table.

There are some work-arounds:

Individual column/row values: You might have a long value in your results like a cluster ID that you don't want to retype. For this case, you can click the little blue "expand" button and from the dialog that opens you can copy the value;
image

image

Multiple rows of values: For this you could use the Download as CSV menu.

@LeeDr LeeDr added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jul 21, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@dej611
Copy link
Contributor

dej611 commented Jul 21, 2021

The table itself has no blocking on user selection, but the drag and drop has some specific css to prevent the user to select the text.
@mbondyra you think it is possible to selectively disable the css block?
Not sure it is worth it as there's already a workaround.

@ghudgins
Copy link
Contributor

another idea for a designer to 🤔 is to include a copy action (in addition to filter in / filter out / expand)

@ghudgins ghudgins mentioned this issue Jul 21, 2021
29 tasks
@LeeDr
Copy link
Author

LeeDr commented Jul 21, 2021

I'm no UX expert, but I would think most people would just expect the normal behavior that they can select text on the screen.

BUT, I know there are requests to track/audit which users download CSV files from Kibana, and there's a feature control for downloading CSV, so maybe we don't want users to be able to copy text from a Kibana page?

image

@mbondyra
Copy link
Contributor

mbondyra commented Jul 28, 2021

Sorry for the late reply! I think it would be working fine if we add user-select: initial on the .lnsVisualizationContainer which is a child for lnsDragDrop. So basically, after a quick testing, I've just added the above line here: https://github.com/elastic/kibana/blob/master/x-pack/plugins/lens/public/visualization_container.scss#L2 and it worked fine.

Will double-check and test more thouroughly once I get to this issue.

@timroes
Copy link
Contributor

timroes commented Jul 28, 2021

Given that we have the same behavior in all data grids, I think @LeeDr you might want to fill that issue also for EUI, since we otherwise just have a lens specific fix, but not in classical data table or discover (in the future), or all the other places using data grid.

@mbondyra
Copy link
Contributor

@timroes the problem was caused by drag and drop implementation in Lens, it doesn't happen in eui/other data tables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants