Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet]: No error popups for incomplete queries entered in search box on Agent Policies and Enrollment tokens tab. #106378

Closed
amolnater-qasource opened this issue Jul 21, 2021 · 8 comments
Labels
bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@amolnater-qasource
Copy link

Kibana version: 7.14.0 BC-3 Kibana cloud environment

Host OS and Browser version: All, All

Build details:

Build: 42545
Commit c314921a9893e0b46d9a3958f5520e3d6b1ce7d5

Preconditions:

  1. 7.14.0 BC-3 Kibana cloud environment should be available.

Steps to reproduce:

  1. Login to Kibana environment.
  2. Navigate to Agents tab and enter any incomplete search query say agent id:
  3. Observe Error popups for incomplete query.
  4. Navigate to Policies tab and enter any incomplete search query say ingest-agent-policies.name :
  5. Observe no error popups for incomplete query on Agent Policies tab.

Note:

  • This issue is also observed on Enrollment Tokens and Security> Endpoints tab.

Expected Result:
Error popups should be displayed for incomplete queries entered in search box on Agent Policies tab.

Screenshot:
3

What's working fine?:
5

@amolnater-qasource amolnater-qasource added bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 21, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@amolnater-qasource
Copy link
Author

amolnater-qasource commented Jul 21, 2021

@manishgupta-qasource Please review.

@manishgupta-qasource
Copy link

Reviewed & Assigned to @jen-huang

CC: @EricDavisX

@jen-huang jen-huang removed their assignment Jul 21, 2021
@jen-huang jen-huang removed the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Jul 21, 2021
@jen-huang
Copy link
Contributor

Feels like this could be related to #106197.

@hop-dev
Copy link
Contributor

hop-dev commented Jul 22, 2021

I think it is @jen-huang. Though at the moment turning on the errors would error for some queries I think are valid, I'll pick this up once I get a steer on #106197

@hop-dev hop-dev self-assigned this Jul 22, 2021
@hop-dev
Copy link
Contributor

hop-dev commented Jul 30, 2021

@jen-huang I believe we suppress errors at the moment because we run the search on every change to the search term, there is a bit of a difference in how we search in the different fleet tabs:

  • agents & data streams: search only when ⏎ is pressed, show syntax errors
  • agent policies & enrolment tokens: search on every change to the search input, suppress errors

My instinct would be to move all to only searching on ⏎ and displaying errors if there are any. What do you think?

@hop-dev
Copy link
Contributor

hop-dev commented Aug 3, 2021

After speaking to @nchaulet and @kpollich about this, I have created a separate issue to normalise the search behaviour across the fleet tabs #107546, I am happy to keep this open in the meantime.

@hop-dev hop-dev removed their assignment Aug 3, 2021
@jen-huang
Copy link
Contributor

I'm going to close this in favor of #107546, as resolving that will provide a general solution/UX pattern across our search UIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

5 participants