Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

License checker incorrectly detects EUI as Apache #105614

Open
chandlerprall opened this issue Jul 14, 2021 · 2 comments
Open

License checker incorrectly detects EUI as Apache #105614

chandlerprall opened this issue Jul 14, 2021 · 2 comments
Labels
bug Fixes for quality problems that affect the customer experience impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort Team:Operations Team label for Operations Team

Comments

@chandlerprall
Copy link
Contributor

Originally pointed out in #105127 (comment) [and this will also affect the charts library]

Starting in v35, we're using "license": "SEE LICENSE IN LICENSE.txt", in EUI's package.json to avoid npm/yarn's warning about a non-SPDX license (npm/npm#8795). However, the license-checker module used by Kibana falls back to a regex test which is detecting the Apache mention in LICENSE.txt

I could check with legal about removing the Apache part from our license notice, but even so I believe license-checker wouldn't pick up the correct license as it has no knowledge of ELv2 or SSPL.

Another thought I had is to expand Kibana's license overrides logic to allow version ranges, e.g. @elastic/eui@>=35.0.0 instead of requiring exact matches.
@chandlerprall chandlerprall added bug Fixes for quality problems that affect the customer experience Team:Operations Team label for Operations Team labels Jul 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@chandlerprall chandlerprall mentioned this issue Jul 14, 2021
Merged
@ghudgins
Copy link
Contributor

There is a similar issue in https://github.com/elastic/elastic-charts - @markov00 and I will 👀 this for the solution we should also incorporate there as well

@nickpeihl nickpeihl mentioned this issue Aug 16, 2021
Open
@markov00 markov00 mentioned this issue Sep 7, 2021
Merged
@tylersmalley tylersmalley added 1 and removed 1 labels Oct 11, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Nov 5, 2021
@tylersmalley tylersmalley removed loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. EnableJiraSync labels Mar 16, 2022
@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort labels Mar 22, 2022
@tylersmalley tylersmalley mentioned this issue Sep 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort Team:Operations Team label for Operations Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tylersmalley @chandlerprall @ghudgins @elasticmachine