Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Latency correlations: Do not include comparison date range #105049

Closed
sophiec20 opened this issue Jul 9, 2021 · 2 comments · Fixed by #104644
Closed

[APM] Latency correlations: Do not include comparison date range #105049

sophiec20 opened this issue Jul 9, 2021 · 2 comments · Fixed by #104644
Assignees
Labels
apm:correlations bug Fixes for quality problems that affect the customer experience :ml Team:APM All issues that need APM UI Team support v7.14.0

Comments

@sophiec20
Copy link
Contributor

Kibana version:
Found in 7.14.0 BC1

Describe the bug:
When clicking "View Correlations" from the Overview tab for a service, the analysis date range appears to be from the start of the comparison window to the end of the main date picker.

The comparison option is not available in the Transaction or Errors tab, and clicking on "View Correlations" from here will only include the main date picker range.

image

Only the main date picker time range should be used for correlation analysis for the following reasons:

  1. Including the comparison window will sometimes "double" the data being analysed which increases analysis run time. This becomes problematic when very long date ranges are being analysed or in environments already under perf strain.
  2. The user probably did not intend to include the comparison period, as this provide insights when eyeballing time series charts (rather than latency distributions).
  3. Making a change to the underlying correlation analysis code in order to compare time periods would be significant and if required, should be scheduled as a longer exercise.
  4. It will match behaviour from the other tabs

Steps to reproduce:

Compare results when viewing correlations from each service tab, with and without comparison checked.

@sophiec20 sophiec20 added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support :ml v7.14.0 apm:correlations labels Jul 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:correlations bug Fixes for quality problems that affect the customer experience :ml Team:APM All issues that need APM UI Team support v7.14.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants