Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vis_type_heatmap] Implementation with elastic-charts #103633

Closed
1 of 4 tasks
stratoula opened this issue Jun 29, 2021 · 4 comments
Closed
1 of 4 tasks

[Vis_type_heatmap] Implementation with elastic-charts #103633

stratoula opened this issue Jun 29, 2021 · 4 comments
Assignees
Labels
Feature:ElasticCharts Issues related to the elastic-charts library Feature:Heatmap Heatmap visualization impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Meta Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stratoula
Copy link
Contributor

stratoula commented Jun 29, 2021

Describe the feature:
We want to create a new plugin vis_type_heatmap that will use the elastic-charts heatmap implementation.

It should offer the same features as vislib and for some minors, both implementations will exist.

  • We need a new switch for Heatmaps to switch between the two implementations
  • Functional tests needed for the new implementation
  • We should check for heatmap related issues and close anything that is solved with the new implementation
  • The old implementation uses JSON blob and doesn't have explicit params**. This need to change.
  • Heatmap should work with the EUI palettes. The vislib one uses these:

image

Should we also support them on the new implementation or not? --> TBD

Update: Yes we should support them and it will be feasible when this PR will be merged #102636

Note: there are some features missing from elastic-charts elastic/elastic-charts#875

Make it the default

  • Small multiples are supported
  • Display xy titles

Other missing features

Not supported (unless we have user's feedback

  • Color scale (is not working correctly in vislib)
  • Rotate and overwrite color values
  • We always scale to data bounds
@stratoula stratoula added Feature:Heatmap Heatmap visualization Feature:ElasticCharts Issues related to the elastic-charts library Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jun 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/datavis (Feature:ElasticCharts)

@flash1293
Copy link
Contributor

flash1293 commented Jun 29, 2021

Implementation notes:

There is already a heatmap chart renderer used in Lens. To avoid redundant code, it should be reused for the visualize heatmap implementation. These are the steps that need to be taken:

@stratoula stratoula self-assigned this Oct 25, 2021
@stratoula stratoula added the Meta label Nov 15, 2021
@timductive timductive added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Feb 14, 2022
@stratoula
Copy link
Contributor Author

This is closed on v8.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ElasticCharts Issues related to the elastic-charts library Feature:Heatmap Heatmap visualization impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Meta Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants