Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Detections] Load Elastic prebuilt rules button not disabled after clicked #103134

Closed
spong opened this issue Jun 23, 2021 · 6 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Detection Rules Security Solution rules and Detection Engine Feature:Rule Management Security Solution Detection Rule Management area impact:critical This issue should be addressed immediately due to a critical level of impact on the product. QA:Validated Issue has been validated by QA Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.14.0

Comments

@spong
Copy link
Member

spong commented Jun 23, 2021

When initially loading rules via the Load Elastic prebuilt rules button within the All Rules table, the button isn't disable once clicked and doesn't change to a loading state like the corresponding button in the title bar group. This doesn't convey to the user that the click was received, and allows them to click multiple times which results in subsequent calls to installing the prebuilt rules as shown in the gif below.

Desired behavior here would be to disable the button and put it in a loading state just like the corresponding button in the title group.

cc @yiyangliu9286 for any additional UX tweaks here.

@spong spong added bug Fixes for quality problems that affect the customer experience Feature:Detection Rules Security Solution rules and Detection Engine Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Management Security Solution Detection Rule Management area labels Jun 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@spong spong added 7.14 candidate impact:critical This issue should be addressed immediately due to a critical level of impact on the product. labels Jun 28, 2021
@spong
Copy link
Member Author

spong commented Jun 28, 2021

Setting as impact:critical to be fixed for 7.14 as this can result in data redundancy issues and duplicate pre-packaged rules:

image

@ecezalp ecezalp self-assigned this Jun 28, 2021
@ecezalp
Copy link
Contributor

ecezalp commented Jun 28, 2021

PR --> #103568

@MadameSheema
Copy link
Member

@deepikakeshav-qasource can you please validate the fix of this issue in the first BC? Thanks :)

@ghost
Copy link

ghost commented Jul 5, 2021

Hi @MadameSheema ,

We have validated this ticket on 7.14.0 BC1 build and observed that issue is Fixed. Load Elastic prebuilt rules button is disabled after clicked.

Build Details:

VERSION: 7.14.0 BC1
BUILD: 42292
COMMIT: 071a74e02f82b79a4a10026b5c9e02d593112fd4
ARTIFACT: https://staging.elastic.co/7.14.0-8eba2f5f/summary-7.14.0.html

Screenshot:

load_prebuilt_rules.mp4

Hence, we are Closing this ticket and marking as QA Validated.

Thanks!!

@ghost ghost added the QA:Validated Issue has been validated by QA label Jul 5, 2021
@ghost ghost closed this as completed Jul 5, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Detection Rules Security Solution rules and Detection Engine Feature:Rule Management Security Solution Detection Rule Management area impact:critical This issue should be addressed immediately due to a critical level of impact on the product. QA:Validated Issue has been validated by QA Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.14.0
Projects
None yet
Development

No branches or pull requests

4 participants