-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[discuss] Build on top of synthetics or use playwright directly? #102279
Comments
Pinging @elastic/kibana-operations (Team:Operations) |
Journeys/Synthetics wrapper around playwrightPros:
Cons:
|
Consume playwright directlyPros:
Cons:
|
I might be wrong, but If we move test runner into Synthetics, it becomes quite Kibana-specific and more complex project. Plus FTR roadmap should be considered as a part of Synthetics project. Will it ok with Observability team? By comparing listed cons I think consuming playright directly is less painful, but still concerning. Some thoughts:
|
To be clear, that's not what we're looking to do. We're looking to add new types of tests and probably deprecate usage of the FTR or try to reduce it dramatically in the Kibana repo. We'll likely have both solutions for a long while and the FTR roadmap won't become the Observability team's responsibility. We'll still have our own tooling around synthetics to accomplish what we need. |
Closing this for now - we're moving forward with using Playwright with the plan to move to Synthetics. This will be a good test case for anything to follow. |
@elastic/synthetics
is a package which wraps microsoft/playwright by allowing users to definejourney()
s which are made up ofstep()
s, and run against an instance of headless Chrome. Beyond defining the test structure, the fundamental API is provided by playwright via thepage
,browser
,client
, andcontext
parameters passed intojourney()
callbacks.We need to weigh the pros and cons of consuming
@elastic/synthetics
vs usingplaywright
directly. I've tried to get a simple POC together of writing journeys in the Kibana repo and it's been a challenge to adapt the current service system to something that works with synthetics. In the meantime I'm planning to start writing some simple synthetics but there was a question about wether it's worth it to use a wrapper around playwright or if we should just consume it directly... I think there's value in using synthetics but much of it is kind of "potential" value.The text was updated successfully, but these errors were encountered: