Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options list control should not search on formatted numbers #102043

Closed
toby-sutor opened this issue Jun 14, 2021 · 7 comments
Closed

Options list control should not search on formatted numbers #102043

toby-sutor opened this issue Jun 14, 2021 · 7 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Input Control Input controls visualization impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@toby-sutor
Copy link
Contributor

Kibana version: 7.13.1

Describe the bug:
If we create an (experimental) "options list" control in the visualization app, then the format:number:defaultPattern is applied to this control. While this is feasible when displaying data, it is not when searching for data.

For example, looking at the Kibana sample logs data machine.ram field, which is a number, in a format like 20401094656:
Screen Shot 2021-06-14 at 13 21 55

It is displayed in the control with a thousands separator (,):
Screen Shot 2021-06-14 at 13 24 31

The problem is that when searching for a value, for which I would intuitively use the raw value, we now need to provide the formatted value as otherwise it does not match:
Screen Shot 2021-06-14 at 13 25 42

Screen Shot 2021-06-14 at 13 25 54

The workaround is to change the format:number:defaultPattern in the Kibana advanced settings from the default 0,0.[000] to 00.[000]:
Screen Shot 2021-06-14 at 13 27 07

Screen Shot 2021-06-14 at 13 27 13

Since this setting is Kibana global and affects other features as well (where the behavior is indeed desired), I think that this should be changed. Either do not apply number formation to search fields or make them more lenient when searching for the raw-values. Not sure if this is perhaps related to #39211.

@toby-sutor toby-sutor added bug Fixes for quality problems that affect the customer experience Feature:FieldFormatters labels Jun 14, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 14, 2021
@toby-sutor toby-sutor added Team:AppServices and removed needs-team Issues missing a team label labels Jun 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 14, 2021
@Dosant
Copy link
Contributor

Dosant commented Jun 16, 2021

Probably related: #83858

@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Jun 22, 2021
@Dosant Dosant added Feature:Input Control Input controls visualization Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Oct 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@rom1b31
Copy link

rom1b31 commented Oct 8, 2021

Kibana version: 7.13.4

Describe the bug:
It seems that the following behavior could have the same root cause.
Creating an (experimental) "options list" control in the visualization app linked to a keyword field that is not case-sensitive:
Mapping is:

   ...
   "template" : {
      "settings" : {
         "analysis": {
            "normalizer": {
               "uppercase_normalizer": {
                  "type":"custom",
                  "filter":[ "uppercase", "asciifolding" ]
               }
            }
         }
      },
      "mappings" : {
         "properties" : {
            "Name" : { "type" : "keyword", "ignore_above" : 512, "normalizer":"uppercase_normalizer" }
   ...

Then when I enter 'AA' (uppercase) in the field of the options list control, there are results
image

But when I enter 'aa' (lowercase), results appears as above briefly and then the following message replaces the list:

aa doesn't match any options

Looks like if query takes into account the normalizer but the "option list" control overrides the behavior

@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:medium Medium Level of Effort labels Jan 4, 2022
@vadimkibana vadimkibana added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Aug 11, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@flash1293 flash1293 removed the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Aug 12, 2022
@flash1293
Copy link
Contributor

Removing viseditors label as this is about input controls owned by the presentation team

@Heenawter
Copy link
Contributor

Related to #126795

Closing - while this is something to consider when we implement number fields in the new options list control, the old input controls are now deprecated and therefore this will not be fixed there 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Input Control Input controls visualization impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

7 participants