Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Refactor chart annotations #101798

Open
smith opened this issue Jun 9, 2021 · 1 comment
Open

[APM] Refactor chart annotations #101798

smith opened this issue Jun 9, 2021 · 1 comment
Labels
apm:elastic-charts Related issues and bugs to replacing react-vis for Elastic charts blocked Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture

Comments

@smith
Copy link
Contributor

smith commented Jun 9, 2021

Due to elastic/elastic-charts#914, the annotation and active alert management code for charts is all together in one component, or using functions that return react elements that are not components.

Once the Elastic Charts fix is there, factor or the annotation handling (or anything else in the charts that needs to be broken up) into separate components.
@smith smith added blocked Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture apm:elastic-charts Related issues and bugs to replacing react-vis for Elastic charts labels Jun 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
apm:elastic-charts Related issues and bugs to replacing react-vis for Elastic charts blocked Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smith @sorenlouv @elasticmachine