Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics & Logs UI] Change SavedObjectClient.get to SavedObjectClient.resolve for 8.0 #101616

Closed
simianhacker opened this issue Jun 8, 2021 · 3 comments
Closed

[Metrics & Logs UI] Change SavedObjectClient.get to SavedObjectClient.resolve for 8.0 #101616

simianhacker opened this issue Jun 8, 2021 · 3 comments
Labels
Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature required-for-8.0 This work is required to be done before 8.0 lands, bc it relates to a breaking change or similar. Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@simianhacker
Copy link
Member

simianhacker commented Jun 8, 2021 •
edited by zube bot
Loading

Per #100489, we need to change how we are using SavedObjectsClient to be "share-capable".

Change client-side code to use the newly available SavedObjectsClient.resolve API (instead of SavedObjectsClient.get), and handle the new different outcomes (exactMatch, aliasMatch, conflict).
A proof-of-concept of these changes for the index-pattern object type can be found here: afc3490 (PR: #95958).
@simianhacker simianhacker added Feature:Metrics UI Metrics UI feature Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Jun 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@weltenwort
Copy link
Member

weltenwort commented Jun 9, 2021 •
edited
Loading

Currently the Logs UI doesn't use the SavedObjectsClient on the client side. The saved object access is mediated either through other Kibana services (such as IndexPatternService) or the server side.

But we will have to keep this mind to avoid introducing it before this change happens in 8.0.

@sgrodzicki sgrodzicki added this to the Metrics UI 8.0 milestone Jun 14, 2021
@jasonrhodes jasonrhodes added the required-for-8.0 This work is required to be done before 8.0 lands, bc it relates to a breaking change or similar. label Jun 14, 2021
@simianhacker
Copy link
Member Author

There is nothing to do on the "client side" for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature required-for-8.0 This work is required to be done before 8.0 lands, bc it relates to a breaking change or similar. Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@simianhacker @jasonrhodes @sgrodzicki @weltenwort @elasticmachine