Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Localization] Guidelines for large paragraphs and markdown #101557

Closed
Bamieh opened this issue Jun 8, 2021 · 3 comments · Fixed by #104171
Closed

[Localization] Guidelines for large paragraphs and markdown #101557

Bamieh opened this issue Jun 8, 2021 · 3 comments · Fixed by #104171
Assignees
Labels
documentation Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@Bamieh
Copy link
Member

Bamieh commented Jun 8, 2021

Summary

Our i18n guide does not specify how developers should handle internationalizing large paragraphs of text and markdown.

Concerns

Without specific guidelines for devs translators might find them selves in a mix of confusing messages to be translated leading to a few back and forth conversations to understand the context of these messages.

We don't have anything specific for markdown but ideally the i18n messages should not include the actual markdown identifiers (#, *, _, etc)

End goals

Additional documentation is needed in the kbn-i18n/GUIDELINE:

  1. Add a section for handling markdown text
  2. Add a section for handling large paragraphs of text

We handle large text and new lines. we just need to update the guidelines to note that.

Potential solutions

Markdown

After a few discussions with our translators; we need a way to identify markdown messages separately for their parser. One solution is to postfix markdown ids with .markdown for messages containing MD.

we have a list of supported markdown agreed with the translators which we should update the GUIDELINES to list them.

Large paragraphs

We have guidelines about splitting sentences here; https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/GUIDELINE.md#splitting

We can split paragraphs into a few i18n chunks whenever makes sense. we just have to be mindful for the i18n messages to make sense for the translators.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-localization (Team:Localization)

@Bamieh
Copy link
Member Author

Bamieh commented Jun 10, 2021

@Bamieh Bamieh added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Jun 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants