Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-axis labels for "date range" aggregations are unusable #10148

Closed
tbragin opened this issue Feb 2, 2017 · 26 comments
Closed

x-axis labels for "date range" aggregations are unusable #10148

tbragin opened this issue Feb 2, 2017 · 26 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure v5.4.0

Comments

@tbragin
Copy link
Contributor

tbragin commented Feb 2, 2017

When creating any "date range" visualization, labels are always vertical, always attempt to show the full date, and are always cut off.

screen shot 2017-02-01 at 8 13 03 pm

As far as I can tell, it behaves the same way as in Kibana 4, except there the labels were horizontal, so it's not a major regression, but something we should still address.

screen shot 2017-02-01 at 8 05 37 pm

A couple of thoughts:

  • Ideally, we should have a more sane default (show the ranges themselves horizontally?)
  • But more often than not it makes sense to mark these ranges with custom labels. For instance, in a business scenario you may be looking at months or quarters, so we should allow someone to enter a custom label for the range, such as "2017Q1", much like we do for filters in the Filter agg.
@tbragin tbragin added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) bug Fixes for quality problems that affect the customer experience labels Feb 2, 2017
@thomasneirynck
Copy link
Contributor

thomasneirynck commented Jun 30, 2017

this was fixed with the Point Series improvements.

e.g.:
image

@vijaygoturi
Copy link

Hi tbragin,

even i am also looking for your second thought. Did you find any workaround?

@tbragin
Copy link
Contributor Author

tbragin commented Oct 31, 2017

@vijaygoturi Looks like this should be fixed in 5.4. If you upgrade to latest minor version of Kibana (5.6.x) and find it's still a problem, you should file a new issue.

@tbragin tbragin added the v5.4.0 label Oct 31, 2017
@vijaygoturi
Copy link

@tbragin I am working on 5.6 version and still not able to custom label the data range.

@tbragin
Copy link
Contributor Author

tbragin commented Oct 31, 2017

@alexfrancoeur @ppisljar @thomasneirynck Are you able to repro? Do you want a new issue filed, or reopen this one?

@ppisljar
Copy link
Member

ppisljar commented Nov 1, 2017

the only thing introduced by 5.4 is the ability to rotate the labels (have them either horizontally or vertically).

we did not introduce an option to generate custom labels.

@ppisljar ppisljar reopened this Nov 1, 2017
@vijaygoturi
Copy link

vijaygoturi commented Nov 2, 2017

Atleast how can blank the date range ? I do not wish to show the range along the x-axis.

kibana

@ppisljar
Copy link
Member

ppisljar commented Nov 6, 2017

that is possible, either hide the labels or hide whole axis:

screenshot-localhost-5601 2017-11-06 07-15-16-577

@vijaygoturi
Copy link

@ppisljar I need the labels along the x-axis points. But, I want to hide the date range that is appearing due to sub-bucket added for the date range. On unchecking the options, only the labels along the axis are hidded, not the date range label.

@ppisljar
Copy link
Member

ppisljar commented Nov 6, 2017

could you post a screenshot of your aggregation setup ? (the data tab in editor)

@vijaygoturi
Copy link

vijaygoturi commented Nov 6, 2017

@ppisljar
image

image

Even if i specify something in custom label, it only changes the end part of the label and not the date range. I wish to avoid the display of the date range

@ppisljar
Copy link
Member

ppisljar commented Nov 6, 2017

could you try to use Split Bucket Split Series instead of Split Chart ? (your first bucket aggregation)
or do you have a specific reason to use Split Chart ?

@vijaygoturi
Copy link

vijaygoturi commented Nov 6, 2017

@ppisljar There is no split bucket option under Add Sub Buckets.

I want to filter the records for the past 12 weeks from the current date. So I used split chart

@ppisljar
Copy link
Member

ppisljar commented Nov 6, 2017

sorry, i meant split series

@vijaygoturi
Copy link

vijaygoturi commented Nov 6, 2017

@ppisljar Thanks. I am getting what I needed along the x-axis, but the range is now appearing along the y-axis labels.

image
Can I avoid the date range along the y-axis , and replace with some meaningful custom labels without the range?

Moreover after adding the split series, whatever the color codes that i am adding to the graphs are not getting correctly reflected in the shared iframe.

@ppisljar
Copy link
Member

ppisljar commented Nov 6, 2017

i am not really sure what you mean by the range on y axis labels ...
but you could hide the y axis labels all together (probably not what you are after)
the other thing next to the y axis is title ... which is based on the metric used, but you can always override it under the y-axis settings for each of the y axes.

@vijaygoturi
Copy link

@ppisljar My overridden values appear at the end of the date range
image

The one in the black circle is the custom label.

@ppisljar
Copy link
Member

ppisljar commented Nov 6, 2017

this looks like a bug specific to date range agg .... could you open a separate issue for it ? thanks!

@vijaygoturi
Copy link

Is there any category of bug for this?

@ppisljar
Copy link
Member

ppisljar commented Nov 6, 2017

just assign it to me and i'll make sure the right labels are assigned.

@vijaygoturi
Copy link

vijaygoturi commented Nov 6, 2017

@ppisljar How can i assign it to you?

Date range appears along side the custom label in "Split Series" sub-bucket #14786

@vijaygoturi
Copy link

@ppisljar Another issue is the color codes that are assigned during visualization are not getting reflected in the shared iframe

@alexfrancoeur
Copy link

@vijaygoturi I assigned to @ppisljar and added the appropriate labels. I believe
your most recent comment may be related to #13653.

Just to confirm, this issue has been re-opened because we currently do not allow you to customize the x-axis date label. @thomasneirynck @ppisljar is this as simple as adding support for the date formatter function in painless?

@ppisljar
Copy link
Member

ppisljar commented Nov 7, 2017

The dates are formatted by the vislib, we would need to add support for formatting there.
from the code perspective it should be quite simple. if we get a format provided we would just apply it there. We need to figure out how to expose this in UI however.

@alexfrancoeur
Copy link

As a bandaid, couldn't we add a dropdown with a number of common date formatting options? We won't allow for full customization (to start) but instead common date formats. This could be placed directly under x-axis and serve as a quick win for us.

screen shot 2017-11-07 at 12 49 36 pm

@ppisljar ppisljar self-assigned this Nov 8, 2017
@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Sep 16, 2018
@ppisljar ppisljar removed their assignment Feb 11, 2019
@wylieconlon
Copy link
Contributor

I think the various bugs and issues here have been resolved by now, and the remaining issue is open separately: #13784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure v5.4.0
Projects
None yet
Development

No branches or pull requests

7 participants