-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerting UI] Rules list does not give reason why rule is disabled when it is due to license #100065
Comments
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
@mdefazio When the rule is enabled and running, it will show this error state due to license level, with the "Fix" link. When the rule is disabled, it won't show the error message anymore. I was thinking we should add a tooltip to indicate why it is disabled, but should we also have some sort of "Fix" link to open the modal that prompts users to look at their license? If we do that here, should we also do it for the connectors list? Currently connectors disabled due to license only show a tooltip with no link to anything. For reference: this PR added the "Fix" link and has screenshots of what the manage license modal looks like. |
A few questions:
Some initial thoughts (but these may change based on the above questions):
Maybe I'm coming at this wrong, so I'm happy to discuss via Zoom if that's easier. |
No. You can only delete the rule with the higher license (or upgrade the license).
No.
Yes, it is possible. But I don't think we need to show something in the rules list. It will be a bunch of cases for the "non working" connectors: removed, higher license, has connection error, has missing secrets. It will be complicated to display all this reasons in the rules table. User will get the Error for execution rule instead.
No. Disabled rules with the higher license comes only from the import.
Yes.
For rules we have only Fix button when the execution of the alert was failed because it has a higher license. We've got an issue now, because we have imported rules which were never executed before in the current Kibana. cc @mdefazio |
Banner could be a good option. Only one thing I'm worry abut is ' a lot of banners' in case when we have an errors banner for rules |
Thanks for those answers @YulNaumenko . I agree about the risk of too many banners. I'm still hung up on whether this should be presented as an error or not. But perhaps it's the same rationale for the connectors. So for simplicity, let's handle this the same way we do on the connector page. Perhaps when we have a clearer path for licensing in general across kibana, we can come back to this. |
On the rules list, if a rule is disabled due to its rule type having a greater license than Kibana offers, the rule looks disabled but there is no indication of why it is disabled:
On the connectors list, we show a tooltip next to the connector name that gives a reason for the connector being disabled.
If the rule is enabled, it would throw an error, which would then be shown in the status column (with a "Fix" link), but because the rule is disabled, the error state is cleared
The text was updated successfully, but these errors were encountered: