[7.x] [Canvas][tech-debt] Fix SVG not shrinking vertically properly (#…

…73867) (#73904) Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
elastic · Jul 31, 2020 · f8d54d7 · f8d54d7
1 parent b74b8c1
commit f8d54d7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/x-pack/plugins/canvas/canvas_plugin_src/renderers/shape/index.js b/x-pack/plugins/canvas/canvas_plugin_src/renderers/shape/index.js
@@ -75,6 +75,7 @@ export const shape = () => ({
         domNode.removeChild(oldShape);
       }
 
+      domNode.style.lineHeight = 0;
       domNode.appendChild(shapeSvg);
     };
 

diff --git a/x-pack/plugins/canvas/public/components/render_with_fn/render_with_fn.tsx b/x-pack/plugins/canvas/public/components/render_with_fn/render_with_fn.tsx
@@ -5,7 +5,6 @@
  */
 
 import React, { useState, useEffect, useRef, FC, useCallback } from 'react';
-import { useDebounce } from 'react-use';
 
 import { useNotifyService } from '../../services';
 import { RenderToDom } from '../render_to_dom';
@@ -73,7 +72,7 @@ export const RenderWithFn: FC<Props> = ({
     firstRender.current = true;
   }, [domNode]);
 
-  useDebounce(() => handlers.current.resize({ height, width }), 150, [height, width]);
+  useEffect(() => handlers.current.resize({ height, width }), [height, width]);
 
   useEffect(
     () => () => {
-Original file line number
+Diff line change
@@ Expand Up / @@ -75,6 +75,7 @@ export const shape = () => ({ @@
             domNode.removeChild(oldShape);
           }
+          domNode.style.lineHeight = 0;
           domNode.appendChild(shapeSvg);
         };
@@ Expand Down @@