From e676b678d614ff0d4f14e3bca3dbf66e996d6e39 Mon Sep 17 00:00:00 2001 From: Cristina Amico Date: Mon, 20 Sep 2021 15:11:32 +0200 Subject: [PATCH 1/4] [Fleet] Fix missing space between integrations badges (#112448) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> --- .../agent_policy_package_badges.tsx | 63 +++++++++++-------- 1 file changed, 36 insertions(+), 27 deletions(-) diff --git a/x-pack/plugins/fleet/public/components/agent_policy_package_badges.tsx b/x-pack/plugins/fleet/public/components/agent_policy_package_badges.tsx index 02518945cf7a5..9db4f77a02c37 100644 --- a/x-pack/plugins/fleet/public/components/agent_policy_package_badges.tsx +++ b/x-pack/plugins/fleet/public/components/agent_policy_package_badges.tsx @@ -84,33 +84,42 @@ export const AgentPolicyPackageBadges: React.FunctionComponent = ({ )} - {packages.map((pkg, idx) => { - return ( - - - - - // this collides with some EuiText (+img) CSS from the EuiIcon component - // which makes the button large, wide, and poorly layed out - // override those styles until the bug is fixed or we find a better approach - { margin: 'unset', width: '16px' } - } - /> - - {pkg.title} - - - ); - })} + + {packages.map((pkg, idx) => { + return ( + + + + + + // this collides with some EuiText (+img) CSS from the EuiIcon component + // which makes the button large, wide, and poorly layed out + // override those styles until the bug is fixed or we find a better approach + { margin: 'unset', width: '16px' } + } + /> + + {pkg.title} + + + + ); + })} + {showFleetServerWarning && ( <> From 5f994b1d9d01da2b76e55f6d3886955fee4e6064 Mon Sep 17 00:00:00 2001 From: Marco Liberati Date: Mon, 20 Sep 2021 15:54:37 +0200 Subject: [PATCH 2/4] [Lens][Visualize] Align inspector header in Lens and Visualize (#112443) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> --- .../public/embeddable/visualize_embeddable.ts | 6 +++++- x-pack/plugins/lens/public/app_plugin/lens_top_nav.tsx | 4 ++-- x-pack/plugins/lens/public/lens_inspector_service.ts | 3 ++- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/plugins/visualizations/public/embeddable/visualize_embeddable.ts b/src/plugins/visualizations/public/embeddable/visualize_embeddable.ts index 75809bd06ba4a..f5a7349b633eb 100644 --- a/src/plugins/visualizations/public/embeddable/visualize_embeddable.ts +++ b/src/plugins/visualizations/public/embeddable/visualize_embeddable.ts @@ -187,7 +187,11 @@ export class VisualizeEmbeddable if (!adapters) return; return this.deps.start().plugins.inspector.open(adapters, { - title: this.getTitle(), + title: + this.getTitle() || + i18n.translate('visualizations.embeddable.inspectorTitle', { + defaultMessage: 'Inspector', + }), }); }; diff --git a/x-pack/plugins/lens/public/app_plugin/lens_top_nav.tsx b/x-pack/plugins/lens/public/app_plugin/lens_top_nav.tsx index 332d404c6375f..f0785496dcf32 100644 --- a/x-pack/plugins/lens/public/app_plugin/lens_top_nav.tsx +++ b/x-pack/plugins/lens/public/app_plugin/lens_top_nav.tsx @@ -255,7 +255,7 @@ export const LensTopNavMenu = ({ }, }, actions: { - inspect: lensInspector.inspect, + inspect: () => lensInspector.inspect({ title }), exportToCSV: () => { if (!activeData) { return; @@ -335,7 +335,7 @@ export const LensTopNavMenu = ({ setIsSaveModalVisible, uiSettings, unsavedTitle, - lensInspector.inspect, + lensInspector, ] ); diff --git a/x-pack/plugins/lens/public/lens_inspector_service.ts b/x-pack/plugins/lens/public/lens_inspector_service.ts index 6266e7c21f792..d9573962f12d4 100644 --- a/x-pack/plugins/lens/public/lens_inspector_service.ts +++ b/x-pack/plugins/lens/public/lens_inspector_service.ts @@ -7,6 +7,7 @@ import type { Adapters, + InspectorOptions, Start as InspectorStartContract, } from '../../../../src/plugins/inspector/public'; @@ -16,7 +17,7 @@ export const getLensInspectorService = (inspector: InspectorStartContract) => { const adapters: Adapters = createDefaultInspectorAdapters(); return { adapters, - inspect: () => inspector.open(adapters), + inspect: (options?: InspectorOptions) => inspector.open(adapters, options), }; }; From 298de0663d9c0a2fd5a118dfb47cca1da59f015a Mon Sep 17 00:00:00 2001 From: Marco Liberati Date: Mon, 20 Sep 2021 15:56:37 +0200 Subject: [PATCH 3/4] [Lens] Make Formula functional tests less flaky (#112428) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> --- x-pack/test/functional/apps/lens/formula.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/x-pack/test/functional/apps/lens/formula.ts b/x-pack/test/functional/apps/lens/formula.ts index 20ab5e165fda0..f645b2c64629c 100644 --- a/x-pack/test/functional/apps/lens/formula.ts +++ b/x-pack/test/functional/apps/lens/formula.ts @@ -87,6 +87,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { input = await find.activeElement(); await input.type(`Men\'s Clothing`); + await PageObjects.common.sleep(100); + await PageObjects.lens.expectFormulaText(`count(kql='Men\\'s Clothing')`); }); From 1fb0982e0040b5fb43d3b659960836302e537cb7 Mon Sep 17 00:00:00 2001 From: Jonathan Budzenski Date: Mon, 20 Sep 2021 09:28:48 -0500 Subject: [PATCH 4/4] fix prettier errors --- src/plugins/embeddable/public/plugin.tsx | 4 ++-- .../public/tests/customize_panel_modal.test.tsx | 2 +- src/plugins/embeddable/server/plugin.ts | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/plugins/embeddable/public/plugin.tsx b/src/plugins/embeddable/public/plugin.tsx index 801320adcc470..7e393c6fc14e1 100644 --- a/src/plugins/embeddable/public/plugin.tsx +++ b/src/plugins/embeddable/public/plugin.tsx @@ -173,8 +173,8 @@ export class EmbeddablePublicPlugin implements Plugin { const contactCardFactory = new ContactCardEmbeddableFactory( uiActions.executeTriggerActions, - ({} as unknown) as OverlayStart + {} as unknown as OverlayStart ); setup.registerEmbeddableFactory(contactCardFactory.type, contactCardFactory); diff --git a/src/plugins/embeddable/server/plugin.ts b/src/plugins/embeddable/server/plugin.ts index f50bb3a85766d..f9ad0a1bda372 100644 --- a/src/plugins/embeddable/server/plugin.ts +++ b/src/plugins/embeddable/server/plugin.ts @@ -45,8 +45,8 @@ export class EmbeddableServerPlugin implements Plugin