diff --git a/src/plugins/embeddable/public/plugin.tsx b/src/plugins/embeddable/public/plugin.tsx index 801320adcc470..7e393c6fc14e1 100644 --- a/src/plugins/embeddable/public/plugin.tsx +++ b/src/plugins/embeddable/public/plugin.tsx @@ -173,8 +173,8 @@ export class EmbeddablePublicPlugin implements Plugin { const contactCardFactory = new ContactCardEmbeddableFactory( uiActions.executeTriggerActions, - ({} as unknown) as OverlayStart + {} as unknown as OverlayStart ); setup.registerEmbeddableFactory(contactCardFactory.type, contactCardFactory); diff --git a/src/plugins/embeddable/server/plugin.ts b/src/plugins/embeddable/server/plugin.ts index f50bb3a85766d..f9ad0a1bda372 100644 --- a/src/plugins/embeddable/server/plugin.ts +++ b/src/plugins/embeddable/server/plugin.ts @@ -45,8 +45,8 @@ export class EmbeddableServerPlugin implements Plugin = ({ )} - {packages.map((pkg, idx) => { - return ( - - - - - // this collides with some EuiText (+img) CSS from the EuiIcon component - // which makes the button large, wide, and poorly layed out - // override those styles until the bug is fixed or we find a better approach - { margin: 'unset', width: '16px' } - } - /> - - {pkg.title} - - - ); - })} + + {packages.map((pkg, idx) => { + return ( + + + + + + // this collides with some EuiText (+img) CSS from the EuiIcon component + // which makes the button large, wide, and poorly layed out + // override those styles until the bug is fixed or we find a better approach + { margin: 'unset', width: '16px' } + } + /> + + {pkg.title} + + + + ); + })} + {showFleetServerWarning && ( <> diff --git a/x-pack/plugins/lens/public/app_plugin/lens_top_nav.tsx b/x-pack/plugins/lens/public/app_plugin/lens_top_nav.tsx index 332d404c6375f..f0785496dcf32 100644 --- a/x-pack/plugins/lens/public/app_plugin/lens_top_nav.tsx +++ b/x-pack/plugins/lens/public/app_plugin/lens_top_nav.tsx @@ -255,7 +255,7 @@ export const LensTopNavMenu = ({ }, }, actions: { - inspect: lensInspector.inspect, + inspect: () => lensInspector.inspect({ title }), exportToCSV: () => { if (!activeData) { return; @@ -335,7 +335,7 @@ export const LensTopNavMenu = ({ setIsSaveModalVisible, uiSettings, unsavedTitle, - lensInspector.inspect, + lensInspector, ] ); diff --git a/x-pack/plugins/lens/public/lens_inspector_service.ts b/x-pack/plugins/lens/public/lens_inspector_service.ts index 6266e7c21f792..d9573962f12d4 100644 --- a/x-pack/plugins/lens/public/lens_inspector_service.ts +++ b/x-pack/plugins/lens/public/lens_inspector_service.ts @@ -7,6 +7,7 @@ import type { Adapters, + InspectorOptions, Start as InspectorStartContract, } from '../../../../src/plugins/inspector/public'; @@ -16,7 +17,7 @@ export const getLensInspectorService = (inspector: InspectorStartContract) => { const adapters: Adapters = createDefaultInspectorAdapters(); return { adapters, - inspect: () => inspector.open(adapters), + inspect: (options?: InspectorOptions) => inspector.open(adapters, options), }; }; diff --git a/x-pack/test/functional/apps/lens/formula.ts b/x-pack/test/functional/apps/lens/formula.ts index 20ab5e165fda0..f645b2c64629c 100644 --- a/x-pack/test/functional/apps/lens/formula.ts +++ b/x-pack/test/functional/apps/lens/formula.ts @@ -87,6 +87,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { input = await find.activeElement(); await input.type(`Men\'s Clothing`); + await PageObjects.common.sleep(100); + await PageObjects.lens.expectFormulaText(`count(kql='Men\\'s Clothing')`); });