From f26292e0a2c589909ba09ecfee61d33f76f14bae Mon Sep 17 00:00:00 2001 From: Tyler Smalley Date: Tue, 5 May 2020 09:29:48 -0700 Subject: [PATCH] Revert "[SIEM] Adds 'Configure connector' Cypress test (#64807)" (#65297) This reverts commit 5c2fb4ce386ccba823d6b2b7e834ff9443c180e2. --- .../integration/cases_connectors.spec.ts | 47 ----------------- x-pack/plugins/siem/cypress/objects/case.ts | 14 ----- .../plugins/siem/cypress/screens/all_cases.ts | 2 - .../siem/cypress/screens/configure_cases.ts | 30 ----------- .../plugins/siem/cypress/tasks/all_cases.ts | 10 +--- .../siem/cypress/tasks/configure_cases.ts | 52 ------------------- 6 files changed, 1 insertion(+), 154 deletions(-) delete mode 100644 x-pack/plugins/siem/cypress/integration/cases_connectors.spec.ts delete mode 100644 x-pack/plugins/siem/cypress/screens/configure_cases.ts delete mode 100644 x-pack/plugins/siem/cypress/tasks/configure_cases.ts diff --git a/x-pack/plugins/siem/cypress/integration/cases_connectors.spec.ts b/x-pack/plugins/siem/cypress/integration/cases_connectors.spec.ts deleted file mode 100644 index 2d650b1bbd9d1..0000000000000 --- a/x-pack/plugins/siem/cypress/integration/cases_connectors.spec.ts +++ /dev/null @@ -1,47 +0,0 @@ -/* - * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one - * or more contributor license agreements. Licensed under the Elastic License; - * you may not use this file except in compliance with the Elastic License. - */ -import { serviceNowConnector } from '../objects/case'; - -import { TOASTER } from '../screens/configure_cases'; - -import { goToEditExternalConnection } from '../tasks/all_cases'; -import { - addServiceNowConnector, - openAddNewConnectorOption, - saveChanges, - selectLastConnectorCreated, -} from '../tasks/configure_cases'; -import { loginAndWaitForPageWithoutDateRange } from '../tasks/login'; - -import { CASES } from '../urls/navigation'; - -describe('Cases connectors', () => { - before(() => { - cy.server(); - cy.route('POST', '**/api/action').as('createConnector'); - cy.route('POST', '**/api/cases/configure').as('saveConnector'); - }); - - it('Configures a new connector', () => { - loginAndWaitForPageWithoutDateRange(CASES); - goToEditExternalConnection(); - openAddNewConnectorOption(); - addServiceNowConnector(serviceNowConnector); - - cy.wait('@createConnector') - .its('status') - .should('eql', 200); - cy.get(TOASTER).should('have.text', "Created 'New connector'"); - - selectLastConnectorCreated(); - saveChanges(); - - cy.wait('@saveConnector', { timeout: 10000 }) - .its('status') - .should('eql', 200); - cy.get(TOASTER).should('have.text', 'Saved external connection settings'); - }); -}); diff --git a/x-pack/plugins/siem/cypress/objects/case.ts b/x-pack/plugins/siem/cypress/objects/case.ts index 12d3f925169af..1c7bc34bca417 100644 --- a/x-pack/plugins/siem/cypress/objects/case.ts +++ b/x-pack/plugins/siem/cypress/objects/case.ts @@ -14,13 +14,6 @@ export interface TestCase { reporter: string; } -export interface Connector { - connectorName: string; - URL: string; - username: string; - password: string; -} - const caseTimeline: Timeline = { title: 'SIEM test', description: 'description', @@ -34,10 +27,3 @@ export const case1: TestCase = { timeline: caseTimeline, reporter: 'elastic', }; - -export const serviceNowConnector: Connector = { - connectorName: 'New connector', - URL: 'https://www.test.service-now.com', - username: 'Username Name', - password: 'password', -}; diff --git a/x-pack/plugins/siem/cypress/screens/all_cases.ts b/x-pack/plugins/siem/cypress/screens/all_cases.ts index 4fa6b69eea7c3..b1e4c66515352 100644 --- a/x-pack/plugins/siem/cypress/screens/all_cases.ts +++ b/x-pack/plugins/siem/cypress/screens/all_cases.ts @@ -39,5 +39,3 @@ export const ALL_CASES_TAGS = (index: number) => { }; export const ALL_CASES_TAGS_COUNT = '[data-test-subj="options-filter-popover-button-Tags"]'; - -export const EDIT_EXTERNAL_CONNECTION = '[data-test-subj="configure-case-button"]'; diff --git a/x-pack/plugins/siem/cypress/screens/configure_cases.ts b/x-pack/plugins/siem/cypress/screens/configure_cases.ts deleted file mode 100644 index 5a1e897c43e27..0000000000000 --- a/x-pack/plugins/siem/cypress/screens/configure_cases.ts +++ /dev/null @@ -1,30 +0,0 @@ -/* - * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one - * or more contributor license agreements. Licensed under the Elastic License; - * you may not use this file except in compliance with the Elastic License. - */ - -export const ADD_NEW_CONNECTOR_OPTION_LINK = - '[data-test-subj="case-configure-add-connector-button"]'; - -export const CONNECTOR = (id: string) => { - return `[data-test-subj='dropdown-connector-${id}']`; -}; - -export const CONNECTOR_NAME = '[data-test-subj="nameInput"]'; - -export const CONNECTORS_DROPDOWN = '[data-test-subj="dropdown-connectors"]'; - -export const PASSWORD = '[data-test-subj="connector-servicenow-password-form-input"]'; - -export const SAVE_BTN = '[data-test-subj="saveNewActionButton"]'; - -export const SAVE_CHANGES_BTN = '[data-test-subj="case-configure-action-bottom-bar-save-button"]'; - -export const SERVICE_NOW_CONNECTOR_CARD = '[data-test-subj=".servicenow-card"]'; - -export const TOASTER = '[data-test-subj="euiToastHeader"]'; - -export const URL = '[data-test-subj="apiUrlFromInput"]'; - -export const USERNAME = '[data-test-subj="connector-servicenow-username-form-input"]'; diff --git a/x-pack/plugins/siem/cypress/tasks/all_cases.ts b/x-pack/plugins/siem/cypress/tasks/all_cases.ts index 8ebe35e173e59..f374532201324 100644 --- a/x-pack/plugins/siem/cypress/tasks/all_cases.ts +++ b/x-pack/plugins/siem/cypress/tasks/all_cases.ts @@ -4,11 +4,7 @@ * you may not use this file except in compliance with the Elastic License. */ -import { - ALL_CASES_NAME, - ALL_CASES_CREATE_NEW_CASE_BTN, - EDIT_EXTERNAL_CONNECTION, -} from '../screens/all_cases'; +import { ALL_CASES_NAME, ALL_CASES_CREATE_NEW_CASE_BTN } from '../screens/all_cases'; export const goToCreateNewCase = () => { cy.get(ALL_CASES_CREATE_NEW_CASE_BTN).click({ force: true }); @@ -17,7 +13,3 @@ export const goToCreateNewCase = () => { export const goToCaseDetails = () => { cy.get(ALL_CASES_NAME).click({ force: true }); }; - -export const goToEditExternalConnection = () => { - cy.get(EDIT_EXTERNAL_CONNECTION).click({ force: true }); -}; diff --git a/x-pack/plugins/siem/cypress/tasks/configure_cases.ts b/x-pack/plugins/siem/cypress/tasks/configure_cases.ts deleted file mode 100644 index 9172e02708ae7..0000000000000 --- a/x-pack/plugins/siem/cypress/tasks/configure_cases.ts +++ /dev/null @@ -1,52 +0,0 @@ -/* - * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one - * or more contributor license agreements. Licensed under the Elastic License; - * you may not use this file except in compliance with the Elastic License. - */ - -import { - ADD_NEW_CONNECTOR_OPTION_LINK, - CONNECTOR, - CONNECTOR_NAME, - CONNECTORS_DROPDOWN, - PASSWORD, - SAVE_BTN, - SAVE_CHANGES_BTN, - SERVICE_NOW_CONNECTOR_CARD, - URL, - USERNAME, -} from '../screens/configure_cases'; -import { MAIN_PAGE } from '../screens/siem_main'; - -import { Connector } from '../objects/case'; - -export const addServiceNowConnector = (connector: Connector) => { - cy.get(SERVICE_NOW_CONNECTOR_CARD).click(); - cy.get(CONNECTOR_NAME).type(connector.connectorName); - cy.get(URL).type(connector.URL); - cy.get(USERNAME).type(connector.username); - cy.get(PASSWORD).type(connector.password); - cy.get(SAVE_BTN).click({ force: true }); -}; - -export const openAddNewConnectorOption = () => { - cy.get(MAIN_PAGE).then($page => { - if ($page.find(SERVICE_NOW_CONNECTOR_CARD).length !== 1) { - cy.wait(1000); - cy.get(ADD_NEW_CONNECTOR_OPTION_LINK).click({ force: true }); - } - }); -}; - -export const saveChanges = () => { - cy.get(SAVE_CHANGES_BTN).click(); -}; - -export const selectLastConnectorCreated = () => { - cy.get(CONNECTORS_DROPDOWN).click({ force: true }); - cy.get('@createConnector') - .its('response') - .then(response => { - cy.get(CONNECTOR(response.body.id)).click(); - }); -};